Update: warn when used with not supported Node versions #4502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** Fixes #4501, refs #4490, refs #4284. Yarn now warns when it detects it is running in a Node version that is not fully supported and warns the user about this. This is different than the hard Node 4+ check in the entry file since in that case, Yarn wuoldn't run at all due to syntax incompatibilities. This warning is to signal that users may encounter unexpected errors but are allowed to use Yarn if they wish. It also adds a new flag to suppress this warning: `--no-node-version-check`. **Test plan** Since we cannot add unsupported Node versions to our CI and spoof the Node version internally, this has to be tested manually, which I did.
|
This change will increase the build size from 9.7 MB to 9.71 MB, an increase of 10.74 KB (0%)
|
|
You can mock the node version if you really want to. |
|
@SimenB yes but that requires us to run Yarn from inside the same process that mocks the version which is not easy or may not be possible with the CLI entry point. |
arcanis
approved these changes
Sep 22, 2017
| @@ -98,6 +100,7 @@ export function main({ | |||
| 'prepend the node executable dir to the PATH in scripts', | |||
| boolify, | |||
| ); | |||
| commander.option('--no-node-version-check', 'do not warn when using a potentially unsupported Node version'); | |||
There was a problem hiding this comment.
--no-node-version-check-or-else-youll-be-fired
|
Trying to understand why was node 7 dropped from support? Cannot find the reason in the documents linked here. |
|
@mkj28 I think I dropped it unintentionally since it is not listed anywhere and it is not LTS. We do not test anything with Node 7 so we do not commit to supporting it. This doesn't mean it is going to break. |
joaolucasl
pushed a commit
to joaolucasl/yarn
that referenced
this pull request
Oct 27, 2017
**Summary** Fixes yarnpkg#4501, refs yarnpkg#4490, refs yarnpkg#4284. Yarn now warns when it detects it is running in a Node version that is not fully supported and warns the user about this. This is different than the hard Node 4+ check in the entry file since in that case, Yarn wouldn't run at all due to syntax incompatibilities. This warning is to signal that users may encounter unexpected errors but are allowed to use Yarn if they wish. It also adds a new flag to suppress this warning: `--no-node-version-check`. **Test plan** Since we cannot add unsupported Node versions to our CI and spoof the Node version internally, this has to be tested manually, which I did.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4501, refs #4490, refs #4284. Yarn now warns when it
detects it is running in a Node version that is not fully
supported and warns the user about this. This is different than
the hard Node 4+ check in the entry file since in that case,
Yarn wouldn't run at all due to syntax incompatibilities. This
warning is to signal that users may encounter unexpected errors
but are allowed to use Yarn if they wish. It also adds a new
flag to suppress this warning:
--no-node-version-check.Test plan
Since we cannot add unsupported Node versions to our CI and
spoof the Node version internally, this has to be tested
manually, which I did.