Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: warn when used with not supported Node versions #4502

Merged
merged 2 commits into from
Sep 22, 2017
Merged

Update: warn when used with not supported Node versions #4502

merged 2 commits into from
Sep 22, 2017

Commits on Sep 19, 2017

  1. Update: warn when used with not supported Node versions 

    **Summary**

Fixes #4501, refs #4490, refs #4284. Yarn now warns when it
detects it is running in a Node version that is not fully
supported and warns the user about this. This is different than
the hard Node 4+ check in the entry file since in that case,
Yarn wuoldn't run at all due to syntax incompatibilities. This
warning is to signal that users may encounter unexpected errors
but are allowed to use Yarn if they wish. It also adds a new
flag to suppress this warning: `--no-node-version-check`.

**Test plan**

Since we cannot add unsupported Node versions to our CI and
spoof the Node version internally, this has to be tested
manually, which I did.
    @BYK
    BYK committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    f1a584f View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2017

  1. Merge branch 'master' into warn-versions

    @BYK
    BYK committed Sep 20, 2017
    Configuration menu
    Copy the full SHA
    b8ffbd3 View commit details
    Browse the repository at this point in the history