Support MSYS{2} bash in bin/yarn #5859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path translation happens differently, or perhaps conditionally dependdding on whether msys detects the target binary is a native Win32 application or not. While Git Bash seems to treat its `winpty` as a Win32 binary, the version of `winpty` which is compatible with MSYS2 does not trigger the path conversion. So, add a case for it to first run `cygpath` on the base dir. To test, `yarn` executed from within bash within MSYS2 correct executes, instead of failing with a path related error. `yarn` continues to execute correctly from within Git Bash.
|
Looks and sounds good to me but calling our expert, @Daniel15, on this before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a case in
bin/yarnto runcygpathon the yarn base dir if the environment is MSYS.Automatic path translation happens differently, or perhaps conditionally, depending on whether msys detects the target binary is a native Win32 application or not. While bash from Git for Windows seems to treat
winptyas a Win32 binary, the version ofwinptywhich is compatible with MSYS2 does not trigger the path conversion.Test plan
yarnexecuted from within bash within MSYS2 correct executes, instead of failing with a pathrelated error.
yarncontinues to execute correctly from within Git Bash.