Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support MSYS{2} bash in bin/yarn #5859

Merged
merged 1 commit into from
May 24, 2018
Merged

Support MSYS{2} bash in bin/yarn #5859

merged 1 commit into from
May 24, 2018

Commits on May 23, 2018

  1. Support MSYS{2} bash in bin/yarn 

    The path translation happens differently, or perhaps conditionally dependdding on whether msys detects
the target binary is a native Win32 application or not. While Git Bash seems to treat its `winpty` as
a Win32 binary, the version of `winpty` which is compatible with MSYS2 does not trigger the path conversion.
So, add a case for it to first run `cygpath` on the base dir.

To test, `yarn` executed from within bash within MSYS2 correct executes, instead of failing with a path
related error. `yarn` continues to execute correctly from within Git Bash.
    Andrew Krieger committed May 23, 2018
    Configuration menu
    Copy the full SHA
    35394ab View commit details
    Browse the repository at this point in the history