Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New flag in the product description file: #694

Merged
merged 5 commits into from
Feb 23, 2024
Merged

Conversation

schubi2
Copy link
Member

@schubi2 schubi2 commented Feb 20, 2024

Due
yast/yast-installation#1109
the user can set systemd-boot und luks2 for the proposal.
The communication will be done via the product description (global/prefered_bootloader = "systemd-boot")
This has the advantage that the product can also define which bootloader should be installed.

Other associated PRs :
yast/yast-installation-control#125
yast/yast-storage-ng#1370

@coveralls
Copy link

Coverage Status

coverage: 87.586% (-0.02%) from 87.604%
when pulling 90f7d7d on systemd_boot_luks2
into 6d4d303 on master.

@jreidinger
Copy link
Member

I will do review on friday due to time off

Copy link
Member

@jreidinger jreidinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. It is still product specific, so it should not affect other products if they do not want systemd boot. And splitting enablement and preferred looks good to me.

@schubi2 schubi2 merged commit 0808245 into master Feb 23, 2024
12 checks passed
@schubi2 schubi2 deleted the systemd_boot_luks2 branch February 23, 2024 15:02
@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #113 successfully finished
✔️ Created OBS submit request #1150200

schubi2 added a commit that referenced this pull request Nov 13, 2024
* added systemd-boot to proposal via product description file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants