Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUKS2 and systemd-boot can be set by the user for the proposal #1109

Closed
wants to merge 1 commit into from

Conversation

schubi2
Copy link
Member

@schubi2 schubi2 commented Feb 19, 2024

in the Configuration dialog:

jsc#PED-1906

Screenshots

Bildschirmfoto_2024-02-16_16-06-43

Other associated PRs :
yast/yast-installation-control#125
yast/yast-bootloader#694
yast/yast-storage-ng#1370

@coveralls
Copy link

Coverage Status

coverage: 40.763% (-0.3%) from 41.105%
when pulling 9d24922 on systemd_boot_luks22
into f4c67bb on master.

@ancorgs
Copy link
Contributor

ancorgs commented Mar 7, 2024

I'm not sure whether we want to use the configuration screen to throw all kind of experiments there.

Have you considered using a role with its own client? I know this doesn't fix exactly in the definition of a role, but since the role allows you to modify most of the settings and allows you to write your own client in which you can ask the user whatever you want or present any information I would feel more comfortable with that, as a testing mechanism.

Check for example the Common Criteria dialog.
https://github.com/yast/system-role-common-criteria/blob/master/src/lib/y2common_criteria/dialogs/installation.rb

if Yast::UI.QueryWidget(Id(:frame), :Value)
# pbkdf2 is default because it can be used by grub2 too
proposal_section["encryption"] = { "type" => "luks2", "pbkdf" => "argon2id",
"password" => Yast::UI.QueryWidget(Id(:pw1), :Value) }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fear storing the password in plain text as part of ProductFeatures may result in password leak in the YaST logs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right. I have seen how you have fixed this problem:
yast/system-role-common-criteria@feb23e6

@schubi2
Copy link
Member Author

schubi2 commented Apr 17, 2024

It is obsolete. Closing

@schubi2 schubi2 closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants