Skip to content

Commit

Permalink
issue-1657: fix resize for netlink device (#1899)
Browse files Browse the repository at this point in the history
issue: #1657

fix proxy argument "--netlink" in e2e test
StartResult future doesn't contain any value as it was moved, so we need to remove this check and fail in message.Send
  • Loading branch information
antonmyagkov authored Aug 29, 2024
1 parent 87bf674 commit 150ea4c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
6 changes: 0 additions & 6 deletions cloud/blockstore/libs/nbd/netlink_device.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -257,12 +257,6 @@ class TNetlinkDevice final

NThreading::TFuture<NProto::TError> Resize(ui64 deviceSizeInBytes) override
{
if (!StartResult.HasValue() || StartResult.GetValue().GetCode() != S_OK)
{
return NThreading::MakeFuture(
MakeError(E_FAIL, "Device is not open"));
}

try {
TNetlinkSocket socket;
TNetlinkMessage message(socket.GetFamily(), NBD_CMD_RECONFIGURE);
Expand Down
2 changes: 1 addition & 1 deletion cloud/blockstore/tests/python/lib/endpoint_proxy.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ def __init__(self, working_dir, unix_socket_path, with_netlink):
]

if with_netlink:
command += "--netlink"
command += ["--netlink"]

super(EndpointProxy, self).__init__(
commands=[command],
Expand Down

0 comments on commit 150ea4c

Please sign in to comment.