-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NBS] Support online resize for PVCs mounted in Filesystem mode #1657
Comments
If it could be downsized it would be great for us (another team) |
@orloffv Downsize is kinda tricky operation, there are many things that could go wrong. I think it would be better to request/implement it via separated feature request |
We need to add isolated e2e test for resize device command to test resize independently from csi driver. |
issue: #1657 ResizeDevice command allows to resize mounted filesystem without restarting endpoint.
issue: #1657 ResizeDevice command allows to resize mounted filesystem without restarting endpoint.
issue: #1657 fix proxy argument "--netlink" in e2e test StartResult future doesn't contain any value as it was moved, so we need to remove this check and fail in message.Send
issue: #1657 fix proxy argument "--netlink" in e2e test StartResult future doesn't contain any value as it was moved, so we need to remove this check and fail in message.Send
We need to do some refactoring: #1748 (comment) |
issue: #1657 doc: https://kubernetes-csi.github.io/docs/volume-expansion.html Only online volume expansion for published volumes is supported
issue: #1657 Discussion: #1748 (comment) RefreshEndpoint was introduced to notify endpoints about new size of the volume: https://github.com/ydb-platform/nbs/blob/main/cloud/blockstore/libs/endpoints_vhost/vhost_server.cpp#L66 We can use it to resize nbd device instead of separate ResizeDevice method. ResizeDevice will be removed in another PR.
issue: #1657 Discussion: #1748 (comment) RefreshEndpoint was introduced to notify endpoints about new size of the volume: https://github.com/ydb-platform/nbs/blob/main/cloud/blockstore/libs/endpoints_vhost/vhost_server.cpp#L66 We can use it to resize nbd device instead of separate ResizeDevice method. ResizeDevice will be removed in another PR.
issue: #1657 Support pvc resize with minikube/nbsd-lightweight Update minikube manifests: Add csi-resizer sidecar to csi controller Allow to expand volume Increase pvc storage limit as it is not possible to expand volume beyond the limit Fix volume resize in nbsd-lightweight. Old blocks count value was cached in several places: mounted volume, storage and storage adapter. Fixed by recreating storage/storage adapter.
issue: #1657 Use mount-utils.Resize to support resize of ext4 and xfs
issue: #1657 Use mount-utils.Resize to support resize of ext4 and xfs
We need NBS disks mounted in
Filesystem
mode via CSI to support online resize up (allowVolumeExpansion
storageclass feature), in order to provide our services a possibility to scale up underlying storage by a client's request.Please help to implement it.
Many thanks!
The text was updated successfully, but these errors were encountered: