Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NBS] Support online resize for PVCs mounted in Filesystem mode #1657

Open
PhantomPhreak opened this issue Jul 23, 2024 · 5 comments
Open

[NBS] Support online resize for PVCs mounted in Filesystem mode #1657

PhantomPhreak opened this issue Jul 23, 2024 · 5 comments
Assignees
Labels
blockstore Add this label to run only cloud/blockstore build and tests on PR

Comments

@PhantomPhreak
Copy link

We need NBS disks mounted in Filesystem mode via CSI to support online resize up (allowVolumeExpansion storageclass feature), in order to provide our services a possibility to scale up underlying storage by a client's request.
Please help to implement it.

Many thanks!

@orloffv
Copy link

orloffv commented Jul 23, 2024

If it could be downsized it would be great for us (another team)

@PhantomPhreak
Copy link
Author

PhantomPhreak commented Jul 23, 2024

@orloffv Downsize is kinda tricky operation, there are many things that could go wrong. I think it would be better to request/implement it via separated feature request

@antonmyagkov
Copy link
Collaborator

@antonmyagkov
Copy link
Collaborator

antonmyagkov commented Aug 23, 2024

We need to add isolated e2e test for resize device command to test resize independently from csi driver.
Discussion: issue-1657: resize nbd device by antonmyagkov · Pull Request #1830 · ydb-platform/nbs

antonmyagkov added a commit that referenced this issue Aug 28, 2024
issue: #1657

ResizeDevice command allows to resize mounted filesystem without restarting endpoint.
antonmyagkov added a commit that referenced this issue Aug 28, 2024
issue: #1657

ResizeDevice command allows to resize mounted filesystem without restarting endpoint.
antonmyagkov added a commit that referenced this issue Aug 28, 2024
antonmyagkov added a commit that referenced this issue Aug 29, 2024
issue: #1657

fix proxy argument "--netlink" in e2e test
StartResult future doesn't contain any value as it was moved, so we need to remove this check and fail in message.Send
antonmyagkov added a commit that referenced this issue Aug 29, 2024
issue: #1657

fix proxy argument "--netlink" in e2e test
StartResult future doesn't contain any value as it was moved, so we need to remove this check and fail in message.Send
@SvartMetal SvartMetal added the blockstore Add this label to run only cloud/blockstore build and tests on PR label Aug 30, 2024
@antonmyagkov
Copy link
Collaborator

We need to do some refactoring: #1748 (comment)

antonmyagkov added a commit that referenced this issue Sep 4, 2024
antonmyagkov added a commit that referenced this issue Sep 13, 2024
issue: #1657

Discussion: #1748 (comment)

RefreshEndpoint was introduced to notify endpoints about new size of the volume: https://github.com/ydb-platform/nbs/blob/main/cloud/blockstore/libs/endpoints_vhost/vhost_server.cpp#L66

We can use it to resize nbd device instead of separate ResizeDevice method.

ResizeDevice will be removed in another PR.
antonmyagkov added a commit that referenced this issue Sep 16, 2024
issue: #1657

Discussion: #1748 (comment)

RefreshEndpoint was introduced to notify endpoints about new size of the volume: https://github.com/ydb-platform/nbs/blob/main/cloud/blockstore/libs/endpoints_vhost/vhost_server.cpp#L66

We can use it to resize nbd device instead of separate ResizeDevice method.

ResizeDevice will be removed in another PR.
antonmyagkov added a commit that referenced this issue Sep 26, 2024
issue: #1657

Support pvc resize with minikube/nbsd-lightweight

Update minikube manifests:
Add csi-resizer sidecar to csi controller
Allow to expand volume
Increase pvc storage limit as it is not possible to expand volume beyond the limit
Fix volume resize in nbsd-lightweight. Old blocks count value was cached in several places: mounted volume, storage and storage adapter. Fixed by recreating storage/storage adapter.
antonmyagkov added a commit that referenced this issue Oct 16, 2024
issue: #1657

Use mount-utils.Resize to support resize of ext4 and xfs
WilyTiger pushed a commit that referenced this issue Oct 16, 2024
issue: #1657

Use mount-utils.Resize to support resize of ext4 and xfs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blockstore Add this label to run only cloud/blockstore build and tests on PR
Projects
None yet
Development

No branches or pull requests

4 participants