Added possibility to report histograms as single-counter as well as multiple-counters in TRequestCounters::TStatCounters #2007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvrazumov
force-pushed
the
users/dvrazumov/single-counter-for-histograms
branch
from
319d200
to
774a8a8
Compare
added 4 commits
October 7, 2024 08:53
…ultiple-counters in TRequestCounters::TStatCounters
dvrazumov
force-pushed
the
users/dvrazumov/single-counter-for-histograms
branch
from
774a8a8
to
6b6ad95
Compare
SvartMetal
reviewed
Oct 11, 2024
drbasic
reviewed
Oct 12, 2024
drbasic
approved these changes
Oct 15, 2024
SvartMetal
approved these changes
Oct 15, 2024
dvrazumov
added a commit
that referenced
this pull request
Oct 15, 2024
…ultiple-counters in TRequestCounters::TStatCounters (#2007) * Added possibility to report histograms as single-counter as well as multiple-counters in TRequestCounters::TStatCounters * Add some tests * review fixes --------- Co-authored-by: Dmitry Razumov <dvrazumov@yandex-team.ru>
WilyTiger
pushed a commit
that referenced
this pull request
Oct 16, 2024
…ultiple-counters in TRequestCounters::TStatCounters (#2007) * Added possibility to report histograms as single-counter as well as multiple-counters in TRequestCounters::TStatCounters * Add some tests * review fixes --------- Co-authored-by: Dmitry Razumov <dvrazumov@yandex-team.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds options to report histograms as either single or multiple counters, providing more flexibility in how monitoring data is collected and reported. Single historgram counter with "le" label makes it possible to calculate quantiles in Grafana monitoring system.
There are a several places in project that report histograms, this PR changes only some of them (specifically
THistBaseclass).The main changes:
ReportHistogramAsMultipleCountersandReportHistogramAsSingleCounterto the diagnostics configuration files (diagnostics.proto) and support them in NBS and FilestoreTHistBase,TRequestCountersand other related classes to handle the new histogram counter optionsTHistBaseis used byTRequestCounters:TRequestCountersis used byTVolumeStatsandTRequestStats