Skip to content

Add basic scale recommender implementation #10780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pixcc merged 5 commits into from
Oct 28, 2024
Merged

Add basic scale recommender implementation #10780

pixcc merged 5 commits into from
Oct 28, 2024

Conversation

@pixcc
Copy link
Member

@pixcc pixcc commented Oct 23, 2024

Changelog category

  • Not for changelog (changelog entry is not required)

@pixcc pixcc requested review from CyberROFL and vporyadke October 23, 2024 13:11
@pixcc pixcc changed the title Add basic recommender implementation Add basic scale recommender implementation Oct 23, 2024
@pixcc pixcc self-assigned this Oct 23, 2024
@github-actions
Copy link

github-actions bot commented Oct 23, 2024 •
edited
Loading

⚪ 2024-10-23 13:19:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for 064dbfd has started.
⚪ 2024-10-23 13:20:02 UTC Artifacts will be uploaded here
⚪ 2024-10-23 13:23:49 UTC ya make is running...
🔴 2024-10-23 13:31:45 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Oct 23, 2024 •
edited
Loading

⚪ 2024-10-23 13:19:29 UTC Pre-commit check linux-x86_64-release-asan for 064dbfd has started.
⚪ 2024-10-23 13:19:40 UTC Artifacts will be uploaded here
⚪ 2024-10-23 13:22:58 UTC ya make is running...
🔴 2024-10-23 13:35:47 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Oct 23, 2024 •
edited
Loading

⚪ 2024-10-23 13:52:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0354368 has started.
⚪ 2024-10-23 13:52:50 UTC Artifacts will be uploaded here
⚪ 2024-10-23 13:56:10 UTC ya make is running...
⚫ 2024-10-23 14:15:56 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Oct 23, 2024 •
edited
Loading

⚪ 2024-10-23 13:53:09 UTC Pre-commit check linux-x86_64-release-asan for 0354368 has started.
⚪ 2024-10-23 13:53:16 UTC Artifacts will be uploaded here
⚪ 2024-10-23 13:56:39 UTC ya make is running...
⚫ 2024-10-23 14:15:58 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Oct 23, 2024 •
edited
Loading

⚪ 2024-10-23 14:18:55 UTC Pre-commit check linux-x86_64-relwithdebinfo for 406eb25 has started.
⚪ 2024-10-23 14:19:06 UTC Artifacts will be uploaded here
⚪ 2024-10-23 14:22:32 UTC ya make is running...
🔴 2024-10-23 14:36:07 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Oct 23, 2024 •
edited
Loading

⚪ 2024-10-23 14:19:07 UTC Pre-commit check linux-x86_64-release-asan for 406eb25 has started.
⚪ 2024-10-23 14:19:18 UTC Artifacts will be uploaded here
⚪ 2024-10-23 14:22:40 UTC ya make is running...
🔴 2024-10-23 14:36:12 UTC Build failed, see the logs. Also see fail summary

CyberROFL
CyberROFL reviewed Oct 23, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Oct 23, 2024 •
edited
Loading

⚪ 2024-10-23 14:48:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for 037c10e has started.
⚪ 2024-10-23 14:48:43 UTC Artifacts will be uploaded here
⚪ 2024-10-23 14:52:08 UTC ya make is running...
🟡 2024-10-23 16:05:18 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41565 35963 0 3 5503 96

⚪ 2024-10-23 16:09:01 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-10-23 16:20:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
98 (only retried tests) 3 0 1 0 94

⚪ 2024-10-23 16:20:30 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-10-23 16:31:39 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
95 (only retried tests) 2 0 0 0 93

🟢 2024-10-23 16:31:46 UTC Build successful.
🟢 2024-10-23 16:32:08 UTC ydbd size 2.8 GiB changed* by +93.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 515f32e merge: 037c10e diff diff %
ydbd size 3 029 524 440 Bytes 3 029 619 728 Bytes +93.1 KiB +0.003%
ydbd stripped size 480 714 168 Bytes 480 728 696 Bytes +14.2 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 23, 2024 •
edited
Loading

⚪ 2024-10-23 14:49:09 UTC Pre-commit check linux-x86_64-release-asan for 037c10e has started.
⚪ 2024-10-23 14:49:21 UTC Artifacts will be uploaded here
⚪ 2024-10-23 14:52:44 UTC ya make is running...
🟡 2024-10-23 16:28:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11692 11506 0 43 38 105

🟢 2024-10-23 16:29:36 UTC Build successful.
🟡 2024-10-23 16:30:10 UTC ydbd size 5.7 GiB changed* by +201.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 515f32e merge: 037c10e diff diff %
ydbd size 6 128 848 184 Bytes 6 129 054 952 Bytes +201.9 KiB +0.003%
ydbd stripped size 1 530 650 352 Bytes 1 530 697 456 Bytes +46.0 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

vporyadke
vporyadke reviewed Oct 23, 2024
View reviewed changes
@pixcc pixcc requested review from CyberROFL and vporyadke October 25, 2024 10:50
@github-actions
Copy link

github-actions bot commented Oct 25, 2024 •
edited
Loading

⚪ 2024-10-25 10:51:45 UTC Pre-commit check linux-x86_64-release-asan for 15cdf31 has started.
⚪ 2024-10-25 10:51:53 UTC Artifacts will be uploaded here
⚪ 2024-10-25 10:55:30 UTC ya make is running...
🟡 2024-10-25 12:46:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11576 11394 0 38 44 100

🟢 2024-10-25 12:47:09 UTC Build successful.
🟡 2024-10-25 12:47:43 UTC ydbd size 5.7 GiB changed* by +243.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 86223ca merge: 15cdf31 diff diff %
ydbd size 6 136 872 480 Bytes 6 137 121 576 Bytes +243.3 KiB +0.004%
ydbd stripped size 1 531 420 816 Bytes 1 531 478 928 Bytes +56.8 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 25, 2024 •
edited
Loading

⚪ 2024-10-25 10:53:06 UTC Pre-commit check linux-x86_64-relwithdebinfo for 15cdf31 has started.
⚪ 2024-10-25 10:53:47 UTC Artifacts will be uploaded here
⚪ 2024-10-25 10:58:24 UTC ya make is running...
🟡 2024-10-25 12:33:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41612 35965 0 7 5540 100

⚪ 2024-10-25 12:36:43 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-25 12:48:54 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
107 (only retried tests) 10 0 0 1 96

🟢 2024-10-25 12:49:01 UTC Build successful.
🟡 2024-10-25 12:49:24 UTC ydbd size 2.8 GiB changed* by +107.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 86223ca merge: 15cdf31 diff diff %
ydbd size 3 032 571 856 Bytes 3 032 681 864 Bytes +107.4 KiB +0.004%
ydbd stripped size 480 494 808 Bytes 480 511 896 Bytes +16.7 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

CyberROFL
CyberROFL approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@CyberROFL CyberROFL left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Для первой итерации норм, но нужно что-то придумать, чтобы избавиться от цикла по всем нодам раз в минуту.

@pixcc pixcc merged commit 3ceed75 into ydb-platform:main Oct 28, 2024
@shnikd shnikd mentioned this pull request Nov 7, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Nov 8, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Nov 13, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Nov 14, 2024
Merged
pixcc added a commit to pixcc/ydb that referenced this pull request Dec 9, 2024
@pixcc
Add basic scale recommender implementation (ydb-platform#10780)
bb0892d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CyberROFL CyberROFL CyberROFL approved these changes

@vporyadke vporyadke vporyadke approved these changes

Assignees

@pixcc pixcc

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pixcc @CyberROFL @vporyadke