Skip to content

Conversation

@molotkov-and
Copy link
Collaborator

@molotkov-and molotkov-and commented Nov 6, 2024

Changelog entry

Adding the ability to register dynamic nodes by certificate. We wont to know how node was registered in node broker. Flag AuthorizeByCertificate is used for this goal.

Formerly this flag sent to node broker but did not store in local db and set to default value after node broker restart.

Changelog category

  • Bugfix

Additional information

...

@github-actions github-actions bot added the bugfix label Nov 6, 2024
@molotkov-and molotkov-and requested a review from ijon November 6, 2024 11:00
@molotkov-and molotkov-and linked an issue Nov 6, 2024 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Nov 6, 2024

2024-11-06 11:03:08 UTC Pre-commit check linux-x86_64-release-asan for d4dae45 has started.
2024-11-06 11:03:19 UTC Artifacts will be uploaded here
2024-11-06 11:06:16 UTC ya make is running...
🟡 2024-11-06 12:14:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9253 9174 0 32 10 37

🟢 2024-11-06 12:15:08 UTC Build successful.
🟢 2024-11-06 12:15:41 UTC ydbd size 5.7 GiB changed* by +37.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 849baa4 merge: d4dae45 diff diff %
ydbd size 6 153 428 928 Bytes 6 153 467 584 Bytes +37.8 KiB +0.001%
ydbd stripped size 1 535 572 688 Bytes 1 535 583 152 Bytes +10.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 6, 2024

2024-11-06 11:03:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for d4dae45 has started.
2024-11-06 11:04:01 UTC Artifacts will be uploaded here
2024-11-06 11:06:59 UTC ya make is running...
🟡 2024-11-06 11:53:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15326 13823 0 3 1404 96

2024-11-06 11:54:54 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-06 12:06:15 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
98 (only retried tests) 6 0 0 0 92

🟢 2024-11-06 12:06:23 UTC Build successful.
🟢 2024-11-06 12:06:43 UTC ydbd size 2.8 GiB changed* by +18.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 849baa4 merge: d4dae45 diff diff %
ydbd size 3 040 923 984 Bytes 3 040 942 872 Bytes +18.4 KiB +0.001%
ydbd stripped size 481 720 952 Bytes 481 723 256 Bytes +2.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions github-actions bot added bugfix and removed bugfix labels Nov 15, 2024
@molotkov-and molotkov-and merged commit 087c886 into ydb-platform:main Nov 15, 2024
7 checks passed
@molotkov-and molotkov-and deleted the register-node/node-broker-flag branch November 15, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Save information about node registration type to node broker

2 participants