Skip to content

Conversation

@molotkov-and
Copy link
Collaborator

@molotkov-and molotkov-and commented Nov 18, 2024

Changelog entry

Adding the ability to register dynamic nodes by certificate. We wont to know how node was registered in node broker. Flag AuthorizeByCertificate is used for this goal.

Formerly this flag sent to node broker but did not store in local db and set to default value after node broker restart.

cherry-pick #11315

Changelog category

  • Bugfix

Additional information

...

@molotkov-and molotkov-and requested a review from a team as a code owner November 18, 2024 11:00
@molotkov-and molotkov-and linked an issue Nov 18, 2024 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Nov 18, 2024

2024-11-18 11:01:33 UTC Pre-commit check for deec8ce has started.
2024-11-18 11:04:49 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-11-18 11:11:24 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Nov 18, 2024

2024-11-18 11:02:16 UTC Pre-commit check for deec8ce has started.
2024-11-18 11:05:25 UTC Build linux-x86_64-release-asan is running...
🟢 2024-11-18 11:27:36 UTC Build successful.
2024-11-18 11:27:48 UTC Tests are running...
🔴 2024-11-18 13:37:03 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10319 10229 0 22 26 42

🟢 2024-11-18 13:37:46 UTC ydbd size 5.6 GiB changed* by +33.9 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: db5d438 merge: deec8ce diff diff %
ydbd size 5 995 393 536 Bytes 5 995 428 280 Bytes +33.9 KiB +0.001%
ydbd stripped size 1 502 731 136 Bytes 1 502 738 144 Bytes +6.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 18, 2024

2024-11-18 11:02:24 UTC Pre-commit check for deec8ce has started.
2024-11-18 11:05:02 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-11-18 11:44:04 UTC Build successful.
2024-11-18 11:44:18 UTC Tests are running...
🔴 2024-11-18 13:21:02 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14618 13267 0 11 1300 40

🟢 2024-11-18 13:21:52 UTC ydbd size 8.3 GiB changed* by +40.7 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: db5d438 merge: deec8ce diff diff %
ydbd size 8 863 321 840 Bytes 8 863 363 512 Bytes +40.7 KiB +0.000%
ydbd stripped size 483 938 792 Bytes 483 941 224 Bytes +2.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@molotkov-and molotkov-and force-pushed the register-node/node-broker-flag-merge-24-3 branch from 17e1244 to cd7d717 Compare November 26, 2024 11:37
@github-actions
Copy link

github-actions bot commented Nov 26, 2024

2024-11-26 11:40:43 UTC Pre-commit check for 9bed173 has started.
2024-11-26 11:43:17 UTC Build linux-x86_64-release-asan is running...
🟢 2024-11-26 12:06:09 UTC Build successful.
2024-11-26 12:06:28 UTC Tests are running...
🔴 2024-11-26 14:08:30 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10327 10243 0 17 26 41

🟢 2024-11-26 14:09:12 UTC ydbd size 5.6 GiB changed* by +37.9 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: d309087 merge: 9bed173 diff diff %
ydbd size 5 997 100 792 Bytes 5 997 139 632 Bytes +37.9 KiB +0.001%
ydbd stripped size 1 503 046 336 Bytes 1 503 057 440 Bytes +10.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 26, 2024

2024-11-26 11:40:51 UTC Pre-commit check for 9bed173 has started.
2024-11-26 11:43:24 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-11-26 11:49:43 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Nov 26, 2024

2024-11-26 11:42:19 UTC Pre-commit check for 9bed173 has started.
2024-11-26 11:44:56 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-11-26 12:23:40 UTC Build successful.
2024-11-26 12:23:53 UTC Tests are running...
🔴 2024-11-26 13:50:11 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14652 13303 0 9 1302 38

🟢 2024-11-26 13:51:02 UTC ydbd size 8.3 GiB changed* by +40.7 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: d309087 merge: 9bed173 diff diff %
ydbd size 8 865 410 304 Bytes 8 865 451 984 Bytes +40.7 KiB +0.000%
ydbd stripped size 484 023 464 Bytes 484 025 896 Bytes +2.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@molotkov-and molotkov-and merged commit b9bd17d into ydb-platform:stable-24-3 Nov 27, 2024
8 of 12 checks passed
@molotkov-and molotkov-and deleted the register-node/node-broker-flag-merge-24-3 branch November 27, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Save information about node registration type to node broker

2 participants