Skip to content

Conversation

@snaury
Copy link
Member

@snaury snaury commented Nov 29, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

An unsafe and unsupported feature (in-memory tables) turned out to be too difficult to use in practice. Allow changing this setting for existing tables and make it easier to do so with a C++ client. Additionally enabling in-memory mode for already running tables didn't do anything until reboot, as well as didn't work properly on followers, those deficiencies are fixed.

Fixes #12010.

@github-actions
Copy link

github-actions bot commented Nov 29, 2024

2024-11-29 12:10:44 UTC Pre-commit check for 5b53eaa has started.
2024-11-29 12:13:47 UTC Build linux-x86_64-release-asan is running...
🟢 2024-11-29 12:55:06 UTC Build successful.
2024-11-29 12:55:28 UTC Tests are running...
🔴 2024-11-29 15:06:19 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12230 12105 0 33 53 39

🟢 2024-11-29 15:06:57 UTC ydbd size 5.6 GiB changed* by -7.7 KiB, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 83cc4da merge: 5b53eaa diff diff %
ydbd size 5 998 656 512 Bytes 5 998 648 656 Bytes -7.7 KiB -0.000%
ydbd stripped size 1 503 259 072 Bytes 1 503 259 072 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 29, 2024

2024-11-29 12:11:53 UTC Pre-commit check for 5b53eaa has started.
2024-11-29 12:15:02 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-11-29 12:54:06 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Nov 29, 2024

2024-11-29 12:11:56 UTC Pre-commit check for 5b53eaa has started.
2024-11-29 12:14:49 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-11-29 13:16:57 UTC Build successful.
2024-11-29 13:17:16 UTC Tests are running...
🔴 2024-11-29 15:25:48 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73330 59845 0 13 13432 40

🟢 2024-11-29 15:26:45 UTC ydbd size 8.3 GiB changed* by +2.6 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 83cc4da merge: 5b53eaa diff diff %
ydbd size 8 868 178 656 Bytes 8 868 181 320 Bytes +2.6 KiB +0.000%
ydbd stripped size 484 081 704 Bytes 484 082 088 Bytes +384 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury marked this pull request as ready for review December 2, 2024 09:37
@snaury snaury requested a review from a team as a code owner December 2, 2024 09:37
@snaury snaury enabled auto-merge (squash) December 2, 2024 09:37
@snaury snaury merged commit 985ff54 into ydb-platform:stable-24-3 Dec 2, 2024
8 of 12 checks passed
@snaury snaury deleted the feature-12010-allow-keep-in-memory-alter-family-24-3 branch December 2, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants