Skip to content

Finsh grpc stream without extra empty message for query service. #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dcherednik merged 1 commit into from
Jan 30, 2024
Merged

Finsh grpc stream without extra empty message for query service. #1415

dcherednik merged 1 commit into from
Jan 30, 2024

Conversation

@dcherednik
Copy link
Member

@dcherednik dcherednik commented Jan 30, 2024 •
edited
Loading

Changelog entry

grpc allows to finish stream just without sending extra messages. This patch adds this in to query service.

#1314

Changelog category

  • Improvement

@dcherednik dcherednik requested a review from a team as a code owner January 30, 2024 11:59
@github-actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

⚪ 2024-01-30 12:14:03 UTC Pre-commit check for 16767a7 has started.
⚪ 2024-01-30 12:14:04 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-30 12:49:19 UTC Build successful.
⚪ 2024-01-30 12:49:31 UTC Tests are running...
🟢 2024-01-30 14:23:27 UTC Tests successful.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60264 50968 0 0 9257 39

@github-actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

⚪ 2024-01-30 12:15:46 UTC Pre-commit check for 16767a7 has started.
⚪ 2024-01-30 12:15:48 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-30 12:53:02 UTC Build successful.
⚪ 2024-01-30 12:53:13 UTC Tests are running...
🔴 2024-01-30 14:32:04 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16011 15884 0 23 66 38

@dcherednik dcherednik merged commit 02f3fa6 into ydb-platform:main Jan 30, 2024
This was referenced Jan 30, 2024
Merged
Merged
@Jornydb Jornydb mentioned this pull request Jan 31, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Jan 31, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 31, 2024
Merged
This was referenced Jan 31, 2024
Closed
Merged
This was referenced Feb 1, 2024
Closed
Draft
This was referenced Feb 1, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 3, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 4, 2024
Merged
@shnikd shnikd mentioned this pull request Feb 5, 2024
Closed
@niksaveliev niksaveliev mentioned this pull request Feb 5, 2024
Merged
@shnikd shnikd mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 5, 2024
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 7, 2024
Merged
This was referenced Feb 7, 2024
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 12, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
Merged
Merged
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 26, 2024
Merged
@dcherednik dcherednik deleted the grpc_steram_finish_opt branch March 22, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gridnevvvit gridnevvvit gridnevvvit approved these changes

@dorooleg dorooleg dorooleg approved these changes

Assignees

No one assigned

Labels

improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dcherednik @gridnevvvit @dorooleg