You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Concerns were expressed that EvaluateExpr might behave differently if written inside VIEWs. The prime suspicion was that queries selecting from views would be loaded from the node's query cache and the result of the following query:
-- CREATE VIEW CurrentTimeView WITH (security_invoker = TRUE) AS SELECT CurrentUtcTimestamp();SELECT*FROM CurrentTimeView;
would always be the same.
However, this suspicion turned out to be wrong. No code changes were necessary to ensure the same behaviour of EvaluateExpr written (1) in a view and (2) in a SELECT statement. This PR only adds unit tests.
The reason will be displayed to describe this comment to others. Learn more.
This might be counter-intuitive, but etalonResult[0] is equal to etalonResult[1] at the moment of writing this unit test. @gridnevvvit confirmed that this behaviour is somewhat expected.
⚪ 2024-02-01 14:14:45 UTC Pre-commit check for ae8187a has started.
⚪ 2024-02-01 14:14:47 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-01 14:16:44 UTC Build successful.
⚪ 2024-02-01 14:16:56 UTC Tests are running...
🔴 2024-02-01 14:20:46 UTC Some tests failed, follow the links below.
⚪ 2024-01-31 16:22:32 UTC Pre-commit check for ae8187a has started.
⚪ 2024-01-31 16:22:33 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-31 16:35:40 UTC Build successful.
⚪ 2024-01-31 16:35:52 UTC Tests are running...
🔴 2024-01-31 18:35:06 UTC Some tests failed, follow the links below.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KIKIMR-20819
Concerns were expressed that EvaluateExpr might behave differently if written inside VIEWs. The prime suspicion was that queries selecting from views would be loaded from the node's query cache and the result of the following query:
would always be the same.
However, this suspicion turned out to be wrong. No code changes were necessary to ensure the same behaviour of EvaluateExpr written (1) in a view and (2) in a SELECT statement. This PR only adds unit tests.