Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for EvaluateExpr in VIEWs #1488

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Add unit tests for EvaluateExpr in VIEWs #1488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 90 additions & 3 deletions ydb/core/kqp/ut/view/view_ut.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,17 +60,25 @@ void ExecuteDataDefinitionQuery(TSession& session, const TString& script) {
<< script << "\nThe issues:\n" << result.GetIssues().ToString());
}

TDataQueryResult ExecuteDataModificationQuery(TSession& session, const TString& script) {
TDataQueryResult ExecuteDataModificationQuery(TSession& session,
const TString& script,
const TExecDataQuerySettings& settings = {}
) {
const auto result = session.ExecuteDataQuery(
script,
TTxControl::BeginTx(TTxSettings::SerializableRW()).CommitTx()
TTxControl::BeginTx(TTxSettings::SerializableRW()).CommitTx(),
settings
).ExtractValueSync();
UNIT_ASSERT_C(result.IsSuccess(), "Failed to execute the following DML script:\n"
<< script << "\nThe issues:\n" << result.GetIssues().ToString());

return result;
}

TString GetYsonResults(TSession& session, const TString& query, const TExecDataQuerySettings& settings = {}) {
return FormatResultSetYson(ExecuteDataModificationQuery(session, query, settings).GetResultSet(0));
}

void CompareResults(const TDataQueryResult& first, const TDataQueryResult& second) {
const auto& firstResults = first.GetResultSets();
const auto& secondResults = second.GetResultSets();
Expand All @@ -89,7 +97,7 @@ void InitializeTablesAndSecondaryViews(TSession& session) {

}

Y_UNIT_TEST_SUITE(TKQPViewTest) {
Y_UNIT_TEST_SUITE(TCreateAndDropViewTest) {

Y_UNIT_TEST(CheckCreatedView) {
TKikimrRunner kikimr(TKikimrSettings().SetWithSampleTables(false));
Expand Down Expand Up @@ -377,3 +385,82 @@ Y_UNIT_TEST_SUITE(TSelectFromViewTest) {
}
}
}

Y_UNIT_TEST_SUITE(TEvaluateExprInViewTest) {

Y_UNIT_TEST(EvaluateExpr) {
TKikimrRunner kikimr;
EnableViewsFeatureFlag(kikimr);
auto session = kikimr.GetTableClient().CreateSession().GetValueSync().GetSession();

constexpr const char* viewName = "TheView";
constexpr const char* timeQuery = R"(
SELECT EvaluateExpr(CurrentUtcTimestamp())
)";

const TString creationQuery = std::format(R"(
CREATE VIEW {} WITH (security_invoker = TRUE) AS {};
)",
viewName,
timeQuery
);
ExecuteDataDefinitionQuery(session, creationQuery);

const TString selectFromViewQuery = std::format(R"(
SELECT * FROM {};
)",
viewName
);
TExecDataQuerySettings queryExecutionSettings;
queryExecutionSettings.KeepInQueryCache(true);
const auto executeTwice = [&](const TString& query) {
return TVector<TString>{
GetYsonResults(session, query, queryExecutionSettings),
GetYsonResults(session, query, queryExecutionSettings)
};
};
const auto viewResults = executeTwice(selectFromViewQuery);
const auto etalonResults = executeTwice(timeQuery);
UNIT_ASSERT_EQUAL_C(viewResults[0] < viewResults[1], etalonResults[0] < etalonResults[1],
Copy link
Collaborator Author

@jepett0 jepett0 Jan 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be counter-intuitive, but etalonResult[0] is equal to etalonResult[1] at the moment of writing this unit test. @gridnevvvit confirmed that this behaviour is somewhat expected.

TStringBuilder()
<< "\nQuery cache works differently for EvaluateExpr written (1) in a view versus (2) in a plain SELECT statement.\n"
<< "(1) SELECT from view results: (first call) " << viewResults[0] << ", (second call) " << viewResults[1]
<< "(2) SELECT EvaluateExpr(...) results: (first call) " << etalonResults[0] << ", (second call) " << etalonResults[1] << "\n"
);
}

Y_UNIT_TEST(NakedCallToCurrentTimeFunction) {
TKikimrRunner kikimr;
EnableViewsFeatureFlag(kikimr);
auto session = kikimr.GetTableClient().CreateSession().GetValueSync().GetSession();

constexpr const char* viewName = "TheView";
constexpr const char* timeQuery = R"(
SELECT CurrentUtcTimestamp()
)";

const TString creationQuery = std::format(R"(
CREATE VIEW {} WITH (security_invoker = TRUE) AS {};
)",
viewName,
timeQuery
);
ExecuteDataDefinitionQuery(session, creationQuery);

const TString selectFromViewQuery = std::format(R"(
SELECT * FROM {};
)",
viewName
);
TExecDataQuerySettings queryExecutionSettings;
queryExecutionSettings.KeepInQueryCache(true);
const auto executeTwice = [&](const TString& query) {
return TVector<TString>{
GetYsonResults(session, query, queryExecutionSettings),
GetYsonResults(session, query, queryExecutionSettings)
};
};
const auto viewResults = executeTwice(selectFromViewQuery);
UNIT_ASSERT_LT(viewResults[0], viewResults[1]);
}
}
Loading