Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable DDL in ExecuteScript. Allow not to specify TxControl in QueryService queries #1603

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Enable DDL in ExecuteScript. Allow not to specify TxControl in QueryService queries #1603

merged 3 commits into from
Feb 8, 2024

Conversation

UgnineSirdis
Copy link
Collaborator

Changelog entry

  • Enable DDL in ExecuteScript
  • Allow not to specify TxControl in QueryService queries

Changelog category

  • New feature

Additional information

...

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024 •
edited
Loading

⚪ 2024-02-05 18:15:55 UTC Pre-commit check for 1c5b4a3 has started.
⚪ 2024-02-05 18:15:57 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-05 18:18:04 UTC Build successful.
⚪ 2024-02-05 18:18:16 UTC Tests are running...
🔴 2024-02-05 19:30:58 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58783 49486 0 2 9264 31

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024 •
edited
Loading

⚪ 2024-02-05 18:16:38 UTC Pre-commit check for 1c5b4a3 has started.
⚪ 2024-02-05 18:16:40 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-05 18:19:17 UTC Build successful.
⚪ 2024-02-05 18:19:29 UTC Tests are running...
🔴 2024-02-05 19:52:54 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14552 14458 0 16 48 30

spuchin
spuchin reviewed Feb 8, 2024
View reviewed changes
ydb/core/kqp/session_actor/kqp_session_actor.cpp Outdated
if (QueryState->HasTxControl()) {
const auto& txControl = QueryState->GetTxControl();
bool autoTransaction = false;
if (QueryState->HasTxControl() || (autoTransaction = QueryState->HasImpliedAutostartTransactions())) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Давай плз без присваиваний внутри предиката )

@UgnineSirdis UgnineSirdis requested a review from a team as a code owner February 8, 2024 12:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024 •
edited
Loading

⚪ 2024-02-08 12:14:33 UTC Pre-commit check for 454038b has started.
⚪ 2024-02-08 12:14:35 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-08 12:18:52 UTC Build successful.
⚪ 2024-02-08 12:19:07 UTC Tests are running...
🔴 2024-02-08 14:06:29 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67268 56421 0 1 10826 20

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024 •
edited
Loading

⚪ 2024-02-08 12:15:44 UTC Pre-commit check for 454038b has started.
⚪ 2024-02-08 12:15:47 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-08 12:19:21 UTC Build successful.
⚪ 2024-02-08 12:19:33 UTC Tests are running...
🔴 2024-02-08 13:58:26 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14594 14460 0 23 57 54

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024 •
edited
Loading

⚪ 2024-02-08 15:25:30 UTC Pre-commit check for 16e0c2a has started.
⚪ 2024-02-08 15:25:32 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-08 15:27:50 UTC Build successful.
⚪ 2024-02-08 15:28:00 UTC Tests are running...
🟢 2024-02-08 16:46:51 UTC Tests successful.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67411 56474 0 0 10904 33

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024 •
edited
Loading

⚪ 2024-02-08 15:30:10 UTC Pre-commit check for 16e0c2a has started.
⚪ 2024-02-08 15:30:12 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-08 15:32:40 UTC Build successful.
⚪ 2024-02-08 15:32:49 UTC Tests are running...
🔴 2024-02-08 17:07:58 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14735 14533 0 13 137 52

@UgnineSirdis UgnineSirdis merged commit 9c31292 into ydb-platform:main Feb 8, 2024
2 of 4 checks passed
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 9, 2024
Merged
@serbel324 serbel324 mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 12, 2024
Merged
UgnineSirdis added a commit to UgnineSirdis/ydb that referenced this pull request Feb 12, 2024
@UgnineSirdis
Enable DDL in ExecuteScript. Allow not to specify TxControl in QueryS…
aea8677 
…ervice queries (ydb-platform#1603)
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
UgnineSirdis added a commit that referenced this pull request Feb 19, 2024
@UgnineSirdis
Enable DDL in ExecuteScript. Allow not to specify TxControl in QueryS…
cfdbc77 
…ervice queries (#1603) (#1815)
This was referenced Feb 20, 2024
Merged
Merged
Merged
@UgnineSirdis UgnineSirdis deleted the execute-script-ddl branch February 22, 2024 09:46
@mvgorbunov mvgorbunov mentioned this pull request Feb 22, 2024
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 26, 2024
Merged
@shnikd shnikd mentioned this pull request Feb 27, 2024
Closed
This was referenced Feb 28, 2024
Closed
Closed
@robdrynkin robdrynkin mentioned this pull request Mar 21, 2024
Closed
@niksaveliev niksaveliev mentioned this pull request Apr 8, 2024
Closed
EgorkaZ pushed a commit to EgorkaZ/ydb that referenced this pull request Apr 10, 2024
@UgnineSirdis @EgorkaZ
Enable DDL in ExecuteScript. Allow not to specify TxControl in QueryS…
9fdb2af 
…ervice queries (ydb-platform#1603)
@GrigoriyPA GrigoriyPA mentioned this pull request Apr 24, 2024
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Apr 26, 2024
Closed
@mregrock mregrock mentioned this pull request May 15, 2024
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request May 24, 2024
Closed
This was referenced Jun 7, 2024
Closed
Closed
@CyberROFL CyberROFL mentioned this pull request Jun 19, 2024
Closed
@CyberROFL CyberROFL mentioned this pull request Jul 12, 2024
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Jul 15, 2024
Closed
@CyberROFL CyberROFL mentioned this pull request Jul 30, 2024
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Aug 23, 2024
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spuchin spuchin spuchin approved these changes

Assignees
No one assigned
Labels
new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UgnineSirdis @spuchin