Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick commit 39728d817646a9dcf7d0a7cb6e1edaff97b363e3 #3035

Closed
wants to merge 87 commits into from

Conversation

robdrynkin
Copy link
Collaborator

alexv-smirnov and others added 30 commits February 1, 2024 11:39
* support trailing generic query responses (ydb-platform#1441)

* improving potential bottleneck in grpc layer of the query service (ydb-platform#1278)
Set mkql runtime version, fix tests. (KIKIMR-19847)
* Initial commit

* Fixes

Co-authored-by: Nikolay Shumkov <153636981+shnikd@users.noreply.github.com>
* Fix scrubbing and flapping unittest (ydb-platform#1640)

* Fix leaking blobs via using patching (ydb-platform#1639)

---------

Co-authored-by: kruall <kruall@ydb.tech>
* Yql 17542 simplify alloc in compute actor (ydb-platform#1452)

* YQL-17542 Simplify allocator usage in ComputeActors

* fix build

* fix dup

* YQL-17542 move SaveState LoadState (ydb-platform#1474)

* YQL-17703 always use sized allocator in CA (ydb-platform#1522)

* YQL-17542 split FillIoMaps (ydb-platform#1537)

* YQL-17755 fix drying input up (ydb-platform#1604)

* YQL-17542 split stat (ydb-platform#1553)

* YQL-17542 remove transition guards (ydb-platform#1610)

* YQL-17542 get rid of std::any in handling sources state (ydb-platform#1635)

* YQL-17755 ut for TComputeActorAsyncInputHelperTest::PollAsyncInput (ydb-platform#1626)

* YQL-17542 move TaskRunner dependent Execute to TDqSyncComputeActorBase (ydb-platform#1599)

* YQL-17542 move TaskRunner dependent Execute to TDqSyncComputeActorBase (ydb-platform#1666)
Co-authored-by: Tony-Romanov <150126326+Tony-Romanov@users.noreply.github.com>
Co-authored-by: Iuliia Sidorina <yulia@ydb.tech>
gridnevvvit and others added 27 commits March 8, 2024 17:45
…ment (ydb-platform#2049) (ydb-platform#2595)

Based on: ydb-platform#2049

KIKIMR-20891

CREATE VIEW statement parses (and validates) the select statement saved in the view. It should be parsed in a context isolated from the statements executed before the CREATE VIEW statement (we haven't decided yet on the exact scope of the context of the view's select statement, see [KIKIMR-20656](https://st.yandex-team.ru/KIKIMR-20656)). It is pretty obvious that one should be able to execute the following statement in one go ("one go" = one press of a "run" button in YDB UI):
```sql
-- create view NecessaryInnerView with (security_invoker = true) as select 1;
-- create view ContextTestingView with (security_invoker = true) as select * from `/local/NecessaryInnerView`; -- where `/local/...` is your cluster name

drop view ContextTestingView;
create view ContextTestingView with (security_invoker = true) as select * from `/local/NecessaryInnerView`;
```

However, executing both drop view and create view in one go currently produces and error:
```
DropObject is not yet implemented for intent determination transformer
```
which indicates that the context of the inner query:
```sql
select * from `/local/NecessaryInnerView`
```
is polluted by the previous:
```sql
drop view ContextTestingView;
```
statement.

This problem is fixed by using an empty parsing context for parsing view's inner select statement during handling of CREATE VIEW statement.
Co-authored-by: Vlad Kuznetsov <va.kuznecov@physics.msu.ru>
@robdrynkin robdrynkin requested a review from a team as a code owner March 21, 2024 12:25
@robdrynkin robdrynkin closed this Mar 21, 2024
Copy link

🔴 Unable to merge your PR into the main branch. Please rebase or merge it with the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jepsen: multiple conflicting appends sometimes succeed