Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cms] add start_time in public cms maintenance api #2452

Merged
merged 1 commit into from
Mar 5, 2024
Merged

[cms] add start_time in public cms maintenance api #2452

merged 1 commit into from
Mar 5, 2024

Conversation

shmel1k
Copy link
Member

@shmel1k shmel1k commented Mar 5, 2024

Changelog entry

...

Changelog category

  • New feature
  • Improvement
  • Bugfix

Additional information

...

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024 •
edited
Loading

⚪ 2024-03-05 10:22:55 UTC Pre-commit check for 9bd850f has started.
⚪ 2024-03-05 10:22:57 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-05 10:59:16 UTC Build successful.
⚪ 2024-03-05 10:59:26 UTC Tests are running...
🔴 2024-03-05 11:09:00 UTC Test run completed, no test results found for commit 4d0ebc0. Please check build logs.
⚫ 2024-03-05 11:09:03 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024 •
edited
Loading

⚪ 2024-03-05 10:23:52 UTC Pre-commit check for 9bd850f has started.
⚪ 2024-03-05 10:23:55 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-05 10:58:16 UTC Build successful.
⚪ 2024-03-05 10:58:31 UTC Tests are running...
🔴 2024-03-05 11:08:55 UTC Test run completed, no test results found for commit 4d0ebc0. Please check build logs.
⚫ 2024-03-05 11:09:00 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024 •
edited
Loading

⚪ 2024-03-05 10:23:53 UTC Pre-commit check for 9bd850f has started.
⚪ 2024-03-05 10:23:55 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-05 10:54:59 UTC Build successful.

CyberROFL
CyberROFL requested changes Mar 5, 2024
View reviewed changes
ydb/core/protos/cms.proto Outdated Show resolved Hide resolved
ydb/public/api/protos/draft/ydb_maintenance.proto Outdated Show resolved Hide resolved
ydb/core/cms/cms.cpp Outdated Show resolved Hide resolved
@shmel1k shmel1k force-pushed the feature/cms_add_start_time_in_listnodes branch from 4d0ebc0 to 6269c21 Compare March 5, 2024 11:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024 •
edited
Loading

⚪ 2024-03-05 11:09:47 UTC Pre-commit check for eb9f327 has started.
⚪ 2024-03-05 11:09:48 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-03-05 11:39:48 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024 •
edited
Loading

⚪ 2024-03-05 11:13:42 UTC Pre-commit check for eb9f327 has started.
⚪ 2024-03-05 11:13:44 UTC Build linux-x86_64-release-cmake14 is running...
⚫ 2024-03-05 11:39:47 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024 •
edited
Loading

⚪ 2024-03-05 11:16:36 UTC Pre-commit check for eb9f327 has started.
⚪ 2024-03-05 11:16:38 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-03-05 11:39:48 UTC Check cancelled

@shmel1k shmel1k force-pushed the feature/cms_add_start_time_in_listnodes branch from 6269c21 to 8dc6265 Compare March 5, 2024 11:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024 •
edited
Loading

⚪ 2024-03-05 11:42:43 UTC Pre-commit check for 81241f5 has started.
⚪ 2024-03-05 11:42:44 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-05 11:50:21 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024 •
edited
Loading

⚪ 2024-03-05 11:44:15 UTC Pre-commit check for 81241f5 has started.
⚪ 2024-03-05 11:44:17 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-05 11:58:44 UTC Build successful.
⚪ 2024-03-05 11:58:56 UTC Tests are running...
🔴 2024-03-05 13:49:50 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14926 14737 0 38 122 29

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024 •
edited
Loading

⚪ 2024-03-05 11:44:20 UTC Pre-commit check for 81241f5 has started.
⚪ 2024-03-05 11:44:23 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-05 11:53:29 UTC Build successful.
⚪ 2024-03-05 11:53:39 UTC Tests are running...
🔴 2024-03-05 13:44:30 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68156 57218 0 3 10911 24

@CyberROFL
Copy link
Member

lgtm

@shmel1k shmel1k enabled auto-merge (squash) March 5, 2024 15:36
@shmel1k shmel1k disabled auto-merge March 5, 2024 15:40
@shmel1k shmel1k merged commit 4e25b44 into ydb-platform:main Mar 5, 2024
3 of 5 checks passed
shmel1k added a commit to shmel1k/ydb that referenced this pull request Mar 5, 2024
@shmel1k
[cms] add start_time in public cms maintenance api (ydb-platform#2452)
b6bb2a2
shmel1k added a commit that referenced this pull request Mar 5, 2024
@shmel1k
[cms] add start_time in public cms maintenance api (#2452) (#2472)
5635e2b
This was referenced Mar 6, 2024
Merged
Open
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 7, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Mar 8, 2024
Merged
This was referenced Mar 11, 2024
Merged
Merged
This was referenced Mar 13, 2024
Merged
Merged
This was referenced Mar 20, 2024
Merged
Closed
@robdrynkin robdrynkin mentioned this pull request Mar 21, 2024
Closed
This was referenced Mar 22, 2024
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 26, 2024
Merged
@shnikd shnikd mentioned this pull request Mar 26, 2024
Merged
This was referenced Mar 29, 2024
Merged
Merged
@shnikd shnikd mentioned this pull request Apr 4, 2024
Merged
This was referenced Apr 6, 2024
Merged
Merged
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Apr 24, 2024
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Apr 26, 2024
Closed
@mregrock mregrock mentioned this pull request May 15, 2024
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request May 24, 2024
Closed
This was referenced Jun 7, 2024
Closed
Closed
@CyberROFL CyberROFL mentioned this pull request Jun 19, 2024
Closed
@CyberROFL CyberROFL mentioned this pull request Jul 12, 2024
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Jul 15, 2024
Closed
@CyberROFL CyberROFL mentioned this pull request Jul 30, 2024
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Aug 23, 2024
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyberROFL CyberROFL CyberROFL approved these changes

@spuchin spuchin spuchin approved these changes

Assignees
No one assigned
Labels
new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shmel1k @CyberROFL @spuchin