Skip to content

Conversation

@alexvru
Copy link
Collaborator

@alexvru alexvru commented Apr 1, 2025

Changelog entry

Fix vanishing node bug

Changelog category

  • Bugfix

Description for reviewers

#16581

This fixes vanishing node bug leading to assertion failure when removing some nodes from the cluster using old-style configuration mechanism.

@github-actions github-actions bot added the bugfix label Apr 1, 2025
@github-actions
Copy link

github-actions bot commented Apr 1, 2025

2025-04-01 11:15:06 UTC Pre-commit check linux-x86_64-relwithdebinfo for 13b6196 has started.
2025-04-01 11:15:59 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Apr 1, 2025

2025-04-01 11:15:27 UTC Pre-commit check linux-x86_64-release-asan for 13b6196 has started.
2025-04-01 11:15:36 UTC Artifacts will be uploaded here
2025-04-01 11:16:05 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Apr 1, 2025

🟢 2025-04-01 11:15:37 UTC The validation of the Pull Request description is successful.

@alexvru alexvru force-pushed the distconf/fix-vanishing-node-bug branch from 88bd617 to 679b68e Compare April 1, 2025 11:15
@github-actions
Copy link

github-actions bot commented Apr 1, 2025

2025-04-01 11:24:31 UTC Pre-commit check linux-x86_64-release-asan for f1cdc22 has started.
2025-04-01 11:24:47 UTC Artifacts will be uploaded here
2025-04-01 11:27:44 UTC ya make is running...
🟡 2025-04-01 12:49:39 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12467 12317 0 104 9 37

2025-04-01 12:50:48 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-01 13:04:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
219 (only retried tests) 144 0 41 2 32

2025-04-01 13:04:24 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-01 13:16:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
105 (only retried tests) 38 0 32 4 31

🟢 2025-04-01 13:16:39 UTC Build successful.
🟢 2025-04-01 13:17:10 UTC ydbd size 3.8 GiB changed* by +4.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a1278fe merge: f1cdc22 diff diff %
ydbd size 4 122 452 800 Bytes 4 122 457 168 Bytes +4.3 KiB +0.000%
ydbd stripped size 1 424 529 128 Bytes 1 424 530 664 Bytes +1.5 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 1, 2025

2025-04-01 11:24:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for f1cdc22 has started.
2025-04-01 11:25:14 UTC Artifacts will be uploaded here
2025-04-01 11:28:00 UTC ya make is running...
🟡 2025-04-01 12:25:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19924 18555 0 9 1249 111

2025-04-01 12:27:49 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-01 12:38:34 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
176 (only retried tests) 72 0 2 0 102

2025-04-01 12:38:45 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-04-01 12:48:54 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
143 (only retried tests) 42 0 0 0 101

🟢 2025-04-01 12:49:03 UTC Build successful.
🟢 2025-04-01 12:49:27 UTC ydbd size 2.2 GiB changed* by +2.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a1278fe merge: f1cdc22 diff diff %
ydbd size 2 349 635 424 Bytes 2 349 637 552 Bytes +2.1 KiB +0.000%
ydbd stripped size 491 489 984 Bytes 491 490 432 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru marked this pull request as ready for review April 1, 2025 18:22
@alexvru alexvru enabled auto-merge (squash) April 1, 2025 18:22
@alexvru alexvru merged commit a1d9b65 into ydb-platform:main Apr 2, 2025
12 checks passed
@alexvru alexvru deleted the distconf/fix-vanishing-node-bug branch April 2, 2025 04:52
alexvru added a commit to alexvru/ydb that referenced this pull request Apr 2, 2025
alexvru added a commit to alexvru/ydb that referenced this pull request Apr 2, 2025
@liruoko liruoko added the changelog/f25-3 PR участвует в списке изменений label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix changelog/f25-3 PR участвует в списке изменений

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants