Skip to content

Fix vanishing node bug #16588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexvru merged 1 commit into from
Apr 2, 2025
Merged

Fix vanishing node bug #16588

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ydb/core/blobstorage/nodewarden/distconf_binding.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,12 @@ namespace NKikimr::NStorage {
STLOG(PRI_DEBUG, BS_NODE, NWDC02, "TEvNodeConfigPush", (NodeId, senderNodeId), (Cookie, ev->Cookie),
(SessionId, ev->InterconnectSession), (Binding, Binding), (Record, record));

if (!NodeIdsSet.contains(senderNodeId)) {
// node has been already deleted from the config, but new subscription is coming through -- ignoring it
SendEvent(*ev, TEvNodeConfigReversePush::MakeRejected());
return;
}

// check if we can't accept this message (or else it would make a cycle)
if (record.GetInitial() && senderNodeId == GetRootNodeId()) {
STLOG(PRI_DEBUG, BS_NODE, NWDC28, "TEvNodeConfigPush rejected", (NodeId, senderNodeId),
Expand Down
Loading