Skip to content

Conversation

@alexvru
Copy link
Collaborator

@alexvru alexvru commented Apr 30, 2025

Changelog entry

Fix SSId issue in domains config

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Distconf was not working properly when Domain.SSId field was not set, although process did start correctly with such static configuration. This patch synchronizes this behaviour.

Copy link
Collaborator

@mregrock mregrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Apr 30, 2025

🟢 2025-04-30 16:53:13 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Apr 30, 2025

2025-04-30 16:47:49 UTC Pre-commit check linux-x86_64-release-asan for 79c537f has started.
2025-04-30 16:47:59 UTC Artifacts will be uploaded here
2025-04-30 16:50:43 UTC ya make is running...
🟡 2025-04-30 18:09:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13079 12939 0 73 44 23

2025-04-30 18:10:19 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-30 18:39:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
945 (only retried tests) 850 0 50 22 23

2025-04-30 18:40:09 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-30 19:07:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
729 (only retried tests) 627 0 47 34 21

🟢 2025-04-30 19:07:17 UTC Build successful.
🟢 2025-04-30 19:07:51 UTC ydbd size 3.8 GiB changed* by +84.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4f1f93d merge: 79c537f diff diff %
ydbd size 4 122 209 192 Bytes 4 122 295 792 Bytes +84.6 KiB +0.002%
ydbd stripped size 1 428 905 496 Bytes 1 428 932 760 Bytes +26.6 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 30, 2025

2025-04-30 16:52:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for 79c537f has started.
2025-04-30 16:52:50 UTC Artifacts will be uploaded here
2025-04-30 16:56:18 UTC ya make is running...
🟡 2025-04-30 18:07:25 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20865 19499 0 6 1323 37

2025-04-30 18:09:10 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-30 18:38:07 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
354 (only retried tests) 325 0 1 0 28

2025-04-30 18:38:16 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-04-30 19:05:39 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
109 (only retried tests) 81 0 0 0 28

🟢 2025-04-30 19:05:47 UTC Build successful.
🟢 2025-04-30 19:06:08 UTC ydbd size 2.2 GiB changed* by -5.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 176cc39 merge: 79c537f diff diff %
ydbd size 2 343 301 816 Bytes 2 343 296 088 Bytes -5.6 KiB -0.000%
ydbd stripped size 492 720 608 Bytes 492 720 416 Bytes -192 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru merged commit ae94de2 into ydb-platform:main Apr 30, 2025
18 checks passed
@alexvru alexvru deleted the distconf/fix-ssid-issue branch May 1, 2025 14:27
alexvru added a commit to alexvru/ydb that referenced this pull request May 1, 2025
alexvru added a commit that referenced this pull request May 5, 2025
Fix SSId issue in domains config (merge from main #17934)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants