Skip to content

Conversation

@alexvru
Copy link
Collaborator

@alexvru alexvru commented May 1, 2025

Changelog entry

Fix SSId issue in domains config

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Distconf was not working properly when Domain.SSId field was not set, although process did start correctly with such static configuration. This patch synchronizes this behaviour.

@alexvru alexvru requested a review from a team as a code owner May 1, 2025 14:30
@github-actions
Copy link

github-actions bot commented May 1, 2025

🟢 2025-05-01 14:33:27 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented May 1, 2025

2025-05-01 14:33:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for d8a8b44 has started.
2025-05-01 14:34:01 UTC Artifacts will be uploaded here
2025-05-01 14:36:50 UTC ya make is running...
🟡 2025-05-01 15:38:09 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19315 18022 0 2 1224 67

2025-05-01 15:39:53 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-01 15:59:41 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
137 (only retried tests) 72 0 0 7 58

🟢 2025-05-01 15:59:48 UTC Build successful.
🟢 2025-05-01 16:00:06 UTC ydbd size 2.1 GiB changed* by -96 Bytes, which is <= 0 Bytes vs stable-25-1: OK

ydbd size dash stable-25-1: cf1e35b merge: d8a8b44 diff diff %
ydbd size 2 245 403 408 Bytes 2 245 403 312 Bytes -96 Bytes -0.000%
ydbd stripped size 475 391 768 Bytes 475 391 704 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 1, 2025

2025-05-01 14:34:03 UTC Pre-commit check linux-x86_64-release-asan for d8a8b44 has started.
2025-05-01 14:34:13 UTC Artifacts will be uploaded here
2025-05-01 14:37:04 UTC ya make is running...
🟡 2025-05-01 15:48:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12289 12126 0 60 69 34

2025-05-01 15:49:04 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-01 16:14:09 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
212 (only retried tests) 112 0 7 62 31

2025-05-01 16:14:17 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-01 16:33:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
126 (only retried tests) 34 0 7 54 31

🟢 2025-05-01 16:34:06 UTC Build successful.
🟢 2025-05-01 16:34:35 UTC ydbd size 3.6 GiB changed* by +256 Bytes, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: cf1e35b merge: d8a8b44 diff diff %
ydbd size 3 905 881 520 Bytes 3 905 881 776 Bytes +256 Bytes +0.000%
ydbd stripped size 1 366 559 088 Bytes 1 366 559 088 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru enabled auto-merge May 5, 2025 06:47
@alexvru alexvru merged commit 261a36a into ydb-platform:stable-25-1 May 5, 2025
13 checks passed
@alexvru alexvru deleted the merge/25-1/17934 branch May 5, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants