Stopping transfer and async replication if connection_string is bad #18943
Conversation
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
🟢 |
nshestakov
changed the title
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ DetailsTest history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ DetailsTest history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
nshestakov
added
the
rebase-and-check
github-actions
bot
removed
the
rebase-and-check
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ DetailsTest history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ DetailsTest history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
nshestakov
added
the
rebase-and-check
github-actions
bot
removed
the
rebase-and-check
|
⚪
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
nshestakov
added
the
rebase-and-check
github-actions
bot
removed
the
rebase-and-check
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ DetailsTest history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| return false; | ||
| case NYdb::EStatus::TRANSPORT_UNAVAILABLE: | ||
| for (const auto& issue : status.GetIssues()) { | ||
| if (issue.GetMessage().contains("Misformatted domain name") || issue.GetMessage().contains("Domain name not found")) { |
There was a problem hiding this comment.
Ох, это очень плохая практика. Текст ошибки у нас не является частью апи. Как временное решение ок, но нужно сразу завести тикет на добавление и обработку явного признака.
There was a problem hiding this comment.
There was a problem hiding this comment.
- Без ответственного его никто никогда не сделает. Нужно договориться с конкретной командой/человеком.
- Лучше issue в github.
- Добавить ссылку на issue в коде, а в issue — на этот pr.
2 participants
Changelog entry
...
Changelog category
Description for reviewers
#19070