Skip to content

Do not include data_events/events.h in to datashard.h. Ydb import fix. #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dcherednik merged 1 commit into from
Dec 18, 2023
Merged

Do not include data_events/events.h in to datashard.h. Ydb import fix. #552

dcherednik merged 1 commit into from
Dec 18, 2023

Conversation

@dcherednik
Copy link
Member

@dcherednik dcherednik commented Dec 18, 2023

No description provided.

@dcherednik dcherednik changed the title Do not include data_events/events.h in do datashard.h. Ydb import fix. Do not include data_events/events.h in to datashard.h. Ydb import fix. Dec 18, 2023
@dcherednik dcherednik enabled auto-merge (squash) December 18, 2023 15:12
@UgnineSirdis UgnineSirdis requested review from UgnineSirdis and azevaykin and removed request for azevaykin December 18, 2023 15:31
@va-kuznecov va-kuznecov self-assigned this Dec 18, 2023
@dcherednik dcherednik merged commit 1a5147c into ydb-platform:main Dec 18, 2023
azevaykin added a commit to azevaykin/ydb that referenced this pull request Dec 18, 2023
@azevaykin
Revert "Do not include data_events/events.h in do datashard.h. Ydb im…
aec2735 
…port fix. (ydb-platform#552)"

This reverts commit 1a5147c.
@domwst domwst mentioned this pull request Dec 19, 2023
Merged
azevaykin added a commit that referenced this pull request Dec 19, 2023
@azevaykin
Remove unused include (#559)
5c2b998 
* Revert "Do not include data_events/events.h in do datashard.h. Ydb import fix. (#552)"

This reverts commit 1a5147c.

* Remove #include "write_data.h"
CyberROFL pushed a commit to CyberROFL/ydb that referenced this pull request Dec 19, 2023
@dcherednik @CyberROFL
Do not include data_events/events.h in do datashard.h. Ydb import fix. (
e1fd652 
ydb-platform#552)
CyberROFL pushed a commit to CyberROFL/ydb that referenced this pull request Dec 19, 2023
@azevaykin @CyberROFL
Remove unused include (ydb-platform#559)
2a41e4e 
* Revert "Do not include data_events/events.h in do datashard.h. Ydb import fix. (ydb-platform#552)"

This reverts commit 1a5147c.

* Remove #include "write_data.h"
@alexvru alexvru mentioned this pull request Dec 19, 2023
Merged
@domwst domwst mentioned this pull request Dec 19, 2023
Merged
@rvu1024 rvu1024 mentioned this pull request Dec 19, 2023
Merged
@domwst domwst mentioned this pull request Dec 19, 2023
Merged
@alexvru alexvru mentioned this pull request Dec 19, 2023
Merged
@domwst domwst mentioned this pull request Dec 20, 2023
Merged
@robdrynkin robdrynkin mentioned this pull request Dec 20, 2023
Merged
@vitstn vitstn mentioned this pull request Dec 20, 2023
Merged
@nepal nepal mentioned this pull request Dec 20, 2023
Merged
@Enjection Enjection mentioned this pull request Dec 20, 2023
Merged
This was referenced Dec 21, 2023
Merged
Merged
Merged
@domwst domwst mentioned this pull request Dec 25, 2023
Merged
@Jornydb Jornydb mentioned this pull request Dec 25, 2023
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Dec 27, 2023
Merged
@alexvru alexvru mentioned this pull request Dec 28, 2023
Merged
This was referenced Dec 29, 2023
Merged
Merged
Merged
This was referenced Dec 29, 2023
Closed
Closed
Merged
@alexvru alexvru mentioned this pull request Jan 9, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Jan 10, 2024
Merged
This was referenced Jan 11, 2024
Merged
Merged
@Dark-Avery Dark-Avery mentioned this pull request Jan 15, 2024
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Jan 16, 2024
Merged
@shnikd shnikd mentioned this pull request Jan 16, 2024
Merged
This was referenced Jan 17, 2024
Closed
Merged
@alexvru alexvru mentioned this pull request Jan 18, 2024
Merged
@shnikd shnikd mentioned this pull request Jan 29, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Jan 29, 2024
Closed
@ildar-khisambeev ildar-khisambeev mentioned this pull request Jan 30, 2024
Merged
@Jornydb Jornydb mentioned this pull request Jan 31, 2024
Merged
This was referenced Jan 31, 2024
Closed
Closed
Merged
This was referenced Feb 1, 2024
Closed
Draft
This was referenced Feb 5, 2024
Closed
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@dcherednik dcherednik deleted the fix_ds_extra_includes branch March 22, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UgnineSirdis UgnineSirdis UgnineSirdis approved these changes

Assignees

@va-kuznecov va-kuznecov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dcherednik @UgnineSirdis @va-kuznecov