auditlog: add logins #7546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

ijon merged 2 commits into ydb-platform:main from ijon:auditlog-add-logins

Aug 20, 2024

Collaborator

ijon commented Aug 7, 2024 •

edited

Loading

Add audit logging for login operation.

KIKIMR-21774

Stacked upon #8027, auditlog: refactor ydb/core/audit library interface.

Changelog entry

Add audit logging for login operation.

Changelog category

Improvement

github-actions bot added the improvement label

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

ijon force-pushed the auditlog-add-logins branch from 191224c to d0dfb84 Compare

August 8, 2024 08:51

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

ijon force-pushed the auditlog-add-logins branch from d0dfb84 to 0d3140b Compare

August 8, 2024 11:03

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

ijon force-pushed the auditlog-add-logins branch from 0d3140b to 6f7eb8a Compare

August 11, 2024 20:01

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

ijon force-pushed the auditlog-add-logins branch from 6f7eb8a to e00fdce Compare

August 19, 2024 16:55

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

github-actions bot added improvement and removed improvement labels

ijon added 2 commits

August 20, 2024 00:03


          auditlog: refactor ydb/core/audit library interface

81ca5b1

- separate interface into client and service sides
- change CreateAuditWriter logBackends arg to rvalue ref

KIKIMR-21774


          auditlog: add logins

f972e3a

Add audit logging for login operation.

KIKIMR-21774

ijon force-pushed the auditlog-add-logins branch from e00fdce to f972e3a Compare

August 19, 2024 21:05

github-actions bot commented Aug 19, 2024 •

edited

Loading

⚪ 2024-08-19 21:08:38 UTC Pre-commit check for 7b7ac13 has started.
⚪ 2024-08-19 21:11:46 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-19 21:47:40 UTC Build successful.

github-actions bot commented Aug 19, 2024 •

edited

Loading

⚪ 2024-08-19 21:08:41 UTC Pre-commit check for 7b7ac13 has started.
⚪ 2024-08-19 21:11:49 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-19 23:09:09 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
75865	62212	0	8	13607	38

⚪ 2024-08-19 23:16:22 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-19 23:24:18 UTC Tests successful.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
59 (only retried tests)	32	0	0	0	27

🟢 2024-08-19 23:24:25 UTC Build successful.
🟢 2024-08-19 23:25:01 UTC ydbd size 8.1 GiB changed* by -207.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `0245f52`	merge: `7b7ac13`	diff	diff %
ydbd size	8 743 499 696 Bytes	8 743 287 048 Bytes	-207.7 KiB	-0.002%
ydbd stripped size	475 706 600 Bytes	475 709 480 Bytes	+2.8 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions bot commented Aug 19, 2024 •

edited

Loading

⚪ 2024-08-19 21:08:45 UTC Pre-commit check for 7b7ac13 has started.
⚪ 2024-08-19 21:12:10 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-19 23:34:24 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14093	14000	0	22	35	36

🟢 2024-08-19 23:35:48 UTC Build successful.
🟢 2024-08-19 23:36:15 UTC ydbd size 5.5 GiB changed* by -15.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `0245f52`	merge: `7b7ac13`	diff	diff %
ydbd size	5 883 818 952 Bytes	5 883 803 312 Bytes	-15.3 KiB	-0.000%
ydbd stripped size	1 478 041 392 Bytes	1 478 050 256 Bytes	+8.7 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

ijon requested a review from molotkov-and

August 20, 2024 08:22

molotkov-and approved these changes

View reviewed changes

ijon merged commit b23ee92 into ydb-platform:main

ijon deleted the auditlog-add-logins branch

August 21, 2024 08:25

GrigoriyPA mentioned this pull request

YQ kqprun enable runtime listing by default #8096

Merged

This was referenced Aug 21, 2024

24-2: auditlog: add logins #8103

Merged

24-3: auditlog: add logins #8104

Merged

This was referenced Aug 23, 2024

LOGBROKER 8891 fix parsing queue url #8203

Merged

LOGBROKER 8891 add 4 json sqs requests #8328

Merged

LOGBROKER 8891 list dead letter source queues #8330

Merged

niksaveliev mentioned this pull request

Fix pqv1 max partitions #8485

Merged

This was referenced Aug 30, 2024

fix json map conversion in http proxy #8508

Merged

LOGBROKER 8891 fix not using optional fields in sqs json api properly #8523

Merged

stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request


          auditlog: add logins (ydb-platform#7546)

06b8ff2

Add audit logging for login operation.

KIKIMR-21774

siarheivesialou mentioned this pull request

fix memory leak in ymq proxy #8706

Merged

ijon added a commit that referenced this pull request


          24-2: auditlog: add logins (#8103)

44cda5b

Add audit logging for login operation.

merge #8027 (81ca5b1), #7546 (f972e3a) from main.

KIKIMR-21774

ijon added a commit that referenced this pull request


          24-3: auditlog: add logins (#8104)

e1a142c

Add audit logging for login operation.

merge #8027 (81ca5b1), #7546 (f972e3a) from main.

KIKIMR-21774

niksaveliev mentioned this pull request

Fix CLI max partitions default #8944

Merged

spuchin pushed a commit to spuchin/ydb that referenced this pull request


          24-3: auditlog: add logins (ydb-platform#8104)

15c9a0d

Add audit logging for login operation.

merge ydb-platform#8027 (81ca5b1), ydb-platform#7546 (f972e3a) from main.

KIKIMR-21774

niksaveliev mentioned this pull request

Fix reading without consumer from federation #9136

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels