Skip to content

Conversation

@ijon
Copy link
Collaborator

@ijon ijon commented Aug 19, 2024

  • separate library interface into client and service sides: audit_log.h and audit_log_service.h
  • move all implementation into the single audit_log_impl.cpp
  • change CreateAuditWriter's logBackends arg to rvalue ref

KIKIMR-21774

Changelog category

  • Not for changelog

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

- separate interface into client and service sides
- change CreateAuditWriter logBackends arg to rvalue ref

KIKIMR-21774
@ijon ijon force-pushed the auditlog-refactor-lib-interface branch from 35bd4c0 to 81ca5b1 Compare August 19, 2024 21:04
@github-actions
Copy link

github-actions bot commented Aug 19, 2024

2024-08-19 21:06:51 UTC Pre-commit check for 2bc1421 has started.
2024-08-19 21:09:40 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-19 21:18:39 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 19, 2024

2024-08-19 21:07:11 UTC Pre-commit check for 2bc1421 has started.
2024-08-19 21:09:58 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-19 22:38:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75836 62196 0 6 13604 30

2024-08-19 22:45:47 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-19 22:52:50 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
49 (only retried tests) 22 0 0 0 27

🟢 2024-08-19 22:52:57 UTC Build successful.
🟢 2024-08-19 22:53:30 UTC ydbd size 8.1 GiB changed* by -281.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 0245f52 merge: 2bc1421 diff diff %
ydbd size 8 743 499 696 Bytes 8 743 211 744 Bytes -281.2 KiB -0.003%
ydbd stripped size 475 706 600 Bytes 475 706 472 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 19, 2024

2024-08-19 21:07:36 UTC Pre-commit check for 2bc1421 has started.
2024-08-19 21:10:37 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-19 23:34:13 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14101 13975 0 30 54 42

🟢 2024-08-19 23:35:28 UTC Build successful.
🟢 2024-08-19 23:36:01 UTC ydbd size 5.5 GiB changed* by -97.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 0245f52 merge: 2bc1421 diff diff %
ydbd size 5 883 818 952 Bytes 5 883 718 768 Bytes -97.8 KiB -0.002%
ydbd stripped size 1 478 041 392 Bytes 1 478 039 440 Bytes -1.9 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ijon ijon merged commit c50a8f8 into ydb-platform:main Aug 20, 2024
@ijon ijon deleted the auditlog-refactor-lib-interface branch August 20, 2024 15:31
This was referenced Aug 21, 2024
stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Aug 30, 2024
- separate library interface into client and service sides: `audit_log.h` and `audit_log_service.h`
- move all implementation into the single `audit_log_impl.cpp`
- change `CreateAuditWriter`'s `logBackends` arg to rvalue ref

KIKIMR-21774
ijon added a commit that referenced this pull request Sep 4, 2024
Add audit logging for login operation.

merge #8027 (81ca5b1), #7546 (f972e3a) from main.

KIKIMR-21774
ijon added a commit that referenced this pull request Sep 4, 2024
Add audit logging for login operation.

merge #8027 (81ca5b1), #7546 (f972e3a) from main.

KIKIMR-21774
spuchin pushed a commit to spuchin/ydb that referenced this pull request Sep 9, 2024
Add audit logging for login operation.

merge ydb-platform#8027 (81ca5b1), ydb-platform#7546 (f972e3a) from main.

KIKIMR-21774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants