Skip to content

Commit

Permalink
#744 leaved a puzzle for remaining null
Browse files Browse the repository at this point in the history
  • Loading branch information
skapral committed Feb 15, 2018
1 parent 99ffc95 commit 326d41e
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/main/java/org/takes/facets/fork/FkHitRefresh.java
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,9 @@ private boolean expired() throws IOException {
/**
* Directory contents updated?
* @return TRUE if contents were updated
* @todo #744:30min `null` constant usage in the function
* `directoryUpdated` is violating the key principles, defined
* in README.md file and must be eliminated.
*/
private boolean directoryUpdated() {
this.lock.readLock().lock();
Expand Down

1 comment on commit 326d41e

@0pdd
Copy link
Collaborator

@0pdd 0pdd commented on 326d41e Feb 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 744-7f6a14c2 discovered in src/main/java/org/takes/facets/fork/FkHitRefresh.java and submitted as #802. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but
we discovered it only now.

Please sign in to comment.