String representation Response and Take

[dmzaytsev]

I expect implementations of Response and Take interfaces will be able convert itself to a loggable string but they don't have this feature

---

- ~~`101-e83253e2`/#159~~ - `101-0be068b8`/#174 (by Yegor Bugayenko)

[yegor256]

@dmzaytsev Something like this you have in mind?

interface ConsoleFriendly {
  String toConsole();
}
interface Take extends ConsoleFriendly {
}

right?

[dmzaytsev]

@yegor256 Yes, something like this will be suitable

[davvd]

@yegor256 this task is yours, go ahead

[davvd]

@dmzaytsev thank you for reporting this, I added 15 mins to your acc, transaction 54622993

[davvd]

@dmzaytsev the code made here contains a puzzle 101-0be068b8, which will be resolved soon

[davvd]

@dmzaytsev since there is no milestone yet I set it to "1.0"

[yegor256]

@davvd assign someone else pls

[yegor256]

@dmzaytsev we'll use toString

[davvd]

@davvd assign someone else pls

@yegor256 -30 points to your rating

[davvd]

@davvd assign someone else pls

@yegor256 OK, I will try to assign someone else

[davvd]

@bdragan please go ahead, it's your task now, keep this in mind, and don't hesitate to ask any technical questions you may have; Budget here is 30 mins (keep this principle in mind)

[bdragan]

@dmzaytsev, @yegor256, @davvd I would suggest using Lombok @ToString for this purpose.

Then, for a Take like:
new TkWithType(new TkClasspath(), "text/xsl")
the output would be:
TkWithType(super=TkWrap(origin=org.takes.tk.TkWithType$1@6b601188))
and for a Take like:
new TkFlash(new TkForward(new TkFork(new FkRegex("/", new TkPostMessage()))))
the output is:
TkFlash(origin=TkForward(origin=TkFork(forks=[org.takes.facets.fork.FkRegex@7a2ad171])), cookie=RsFlash)

As you see, classes that don't provide the toString method (including the Takes implemented as anonymous classes) are still printed using the default toString method. Nevertheless, I think we should not exclude these from the toString output (at least the type name is printed, and we can later introduce the proper toString implementations for them as well if needed).

Would you agree?

Also, circular references can be problematic. At the first glance, I would say that there should not be any when it comes to Takes and Responses, am I right?

[yegor256]

@bdragan looks good to me

[bdragan]

@davvd Pull Request #398 created and ready for review.

[davvd]

@davvd Pull Request #398 created and ready for review.

@bdragan thanks, we'll review it soon

[bdragan]

@davvd This resolution of this issue is currently blocked by #403.

[davvd]

@davvd This resolution of this issue is currently blocked by #403.

@bdragan ok, let's wait for #403

[davvd]

@dmzaytsev we waited for #403, it is closed already

[bdragan]

@dmzaytsev @davvd PR #398 has been merged to master.

[dmzaytsev]

@bdragan thanks!

[davvd]

@ypshenychka please, let us know what do you think about this ticket, according to our QA rules

[ypshenychka]

@davvd

davvd commented on 3 Apr
the code made here contains a puzzle 101-0be068b8, which will be resolved soon

According to our QA Rules:

Messages in a ticket always start with a name of a user they are addressed to.

Please correct your message by indicating an addressee in the beginning.

[ypshenychka]

@davvd Please remove assignment from @yegor256 as far as we have label with @bdragan who actually fixed the issue.

[davvd]

@davvd

davvd commented on 3 Apr
the code made here contains a puzzle 101-0be068b8, which will be resolved soon

According to our QA Rules:

Messages in a ticket always start with a name of a user they are addressed to.

Please correct your message by indicating an addressee in the beginning.

@ypshenychka @yegor256 what do you think?

[yegor256]

@davvd assign @bdragan here pls

[davvd]

@davvd assign @bdragan here pls

@yegor256 done, @bdragan is assigned to this task, and is already working on it, AFAIK

[ypshenychka]

@davvd Please remove assignment from @yegor256 and also correct your message (as mentioned in above remark).

[davvd]

@davvd Please remove assignment from @yegor256 and also correct your message (as mentioned in above remark).

@ypshenychka don't pay attention to the assignee, it's a technical issue on our side

[ypshenychka]

@davvd Please correct your message by indicating an addressee in the beginning.

davvd commented on 3 Apr
the code made here contains a puzzle 101-0be068b8, which will be resolved soon

[davvd]

@davvd Please correct your message by indicating an addressee in the beginning.

davvd commented on 3 Apr
the code made here contains a puzzle 101-0be068b8, which will be resolved soon

@ypshenychka fixed, thanks for noticing

[ypshenychka]

@davvd Thank you.

[ypshenychka]

@davvd Quality is acceptable here.

[davvd]

@davvd Thank you.

@ypshenychka no problem :)

[davvd]

@davvd Quality is acceptable here.

@ypshenychka thanks for the QA review, we'll work better next time

[davvd]

@bdragan paied 10 mins to @ypshenychka for QA review (payment ID is 68465482). Thank you, I have added 1 hour to your account in payment/transaction "68465485", time consumed: zero. there is a bonus for fast delivery (m=0). added +60 to your rating, now it is equal to +143

[davvd]

@dmzaytsev last puzzled solved 101-0be068b8/#174