-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#101: Added toString to Takes and Responses. #398
Conversation
@bdragan Thanks, someone will review your pull request soon |
@pinaf it's yours,please review |
@bdragan what issue does this PR fix? Please add a reference to the issue in your first comment. |
@rultor merge |
@pinaf Thanks for the review; I updated the first comment. |
@rultor try to merge |
@bdragan @yegor256 Oops, I failed. You can see the full log here (spent 12min)
|
@yegor256 just in case it is intermittent. we could try the merge again. |
@bdragan why suggesting to create an issue, instead of creating it? :) |
@rultor try to merge again |
@bdragan @yegor256 Oops, I failed. You can see the full log here (spent 7min)
|
@rultor merge |
@rultor try to merge |
@bdragan @yegor256 Oops, I failed. You can see the full log here (spent 12min)
|
@rultor try to merge |
@ypshenychka please, let us know what do you think about this ticket, according to our QA rules |
@rultor deploy pls |
@ypshenychka I confirm |
@davvd Quality is acceptable. |
@ypshenychka thanks for the review, we'll try better next time |
@pinaf 10 mins was added to the account of @ypshenychka (for QA review), in transaction 67489274... I just added 20 mins to your account, many thanks for your contribution (AP-9SB9710087272174H).. 309 hours and 30 mins spent here... review comments (c=5) added as a bonus... +20 to your rating, your total score is +4194 |
This PR contains the implementation of
toString
methods inTake
andResponse
classes, as described in the issue #101.