BkBasicTest.java:67-68: It will be nice to...

[davvd]

Puzzle 516-c8aa6c8f in src/test/java/org/takes/http/BkBasicTest.java:67-68 has to be resolved: It will be nice to refactor tests with Socket usage and replace them to real statements. See usage of BkBasicTest.createMockSocket.... The puzzle was created by lexx on 21-Jan-2016.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code.

[davvd]

@exper0 please proceed, it's yours

[davvd]

@yegor256 since the ticket has no milestone I set it to 1.0

[exper0]

@yegor256 @dmzaytsev @lexx what should I do here? I do not understand the task. What does "real statements" means?

[yegor256]

@exper0 I think that we should get rid of mocking here, since it's a bad thing in general, see http://www.yegor256.com/2014/09/23/built-in-fake-objects.html

[exper0]

@davvd need more time here.

[davvd]

@davvd need more time here.

@exper0 no problem, thanks for letting me know

[exper0]

@davvd please assign to someone else.

[davvd]

@davvd please assign to someone else.

@exper0 30 points deducted from your rating

[davvd]

@davvd please assign to someone else.

@exper0 OK, I will try to assign someone else

[davvd]

@essobedo the task is yours plz proceed

[essobedo]

@davvd the PR is ready to be reviewed thx in advance

[davvd]

@davvd the PR is ready to be reviewed thx in advance

@essobedo OK

[essobedo]

@davvd the PR has been merged, so could you please close the ticket and ask the QA to proceed. Thx in advance.

[essobedo]

@davvd please close the ticket

[essobedo]

@davvd please close the ticket

[essobedo]

@davvd the PR has been merged, so could you please close the ticket and ask the QA to proceed. Thx in advance.

[davvd]

@yegor256 I'm closing the issue...

[davvd]

@elenavolokhova please, check this issue for QA compliance, as per par.24

[elenavolokhova]

@davvd Looks good!

[davvd]

@davvd Looks good!

@elenavolokhova many thanks

[davvd]

@essobedo I added 10 mins to @elenavolokhova (for QA review) in transaction 79352198. done, I added 30 mins in payment 79352218, 100 hours and 1 min spent to complete this. +30 added to your rating, current score is: +315