#533 - mock socket refactoring

[exper0]

#533 - mock socket refactoring

[davvd]

@exper0 Thanks, let me find someone who can review this pull request

[davvd]

@longtimeago it's yours,please review

[longtimeago]

@exper0 I didn't get what is the point of moving this code back from createMockSocket() method?
Do you understand issue you are trying to solve?

[exper0]

@longtimeago absolutely no. I asked about it in #533 but decided it will be faster to create PR with anything. Could you please explain what should I do here?

[longtimeago]

@exper0 from my point of view, the issue is pointless, unless you could get rid of mocking and introduce fake Stream as it was suggested by Yegor

[longtimeago]

@exper0 any updates here?

[exper0]

@longtimeago not yet - I had to set 'away' mode a bit earlier. I will be able to regurn to the task next week

[exper0]

@longtimeago please take a look at latest commit

[longtimeago]

@exper0 nice, thanks!

[longtimeago]

@rultor merge

[rultor]

@rultor merge

@longtimeago Thanks for your request. @yegor256 Please confirm this.

[longtimeago]

@yegor256 ping

[yegor256]

@exper0 this is pointless... by mocking a JDK socket you're basically removing 90% of functionality from our classes. what is there left to test? just a few lines of code that makes calls to JDK sockets? they work, we can see that. but will they work with a real socket? we don't know, since you mock it out. we should use a real socket, not a fake one.

[longtimeago]

@yegor256 hum ... looks like we didn't get your previous comment #533 (comment)

[longtimeago]

@yegor256 This PR stuck is my tasks list. Could you please check?

[davvd]

@elenavolokhova please, review this issue for QA compliance, as per par.24

[elenavolokhova]

@longtimeago
According to our quality rules:

The code reviewer found at least three problems in the code.

Only one issue was found during review.
Please confirm that you will try to find at least three problems next time.

[longtimeago]

@elenavolokhova I confirm

[elenavolokhova]

@davvd Quality is acceptable here.

[davvd]

@davvd Quality is acceptable here.

@elenavolokhova thanks for the QA review, we'll work better next time

[davvd]

@longtimeago added 10 mins to @elenavolokhova, for QA review, payment code is 78668553; thanks, paid, 24 mins to your account, payment ID is 78668566, task took 838 hours and 47 mins to complete; you're getting extra minutes here (c=9); added +24 to your rating, now it is equal to +6246

[yegor256]

@longtimeago everything is good now

[longtimeago]

@yegor256 yep, thanks!