Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all classes inside interfaces to outside #945

Open
fabriciofx opened this issue Jan 16, 2019 · 1 comment · May be fixed by #1370
Open

Move all classes inside interfaces to outside #945

fabriciofx opened this issue Jan 16, 2019 · 1 comment · May be fixed by #1370

Comments

@fabriciofx
Copy link
Contributor

fabriciofx commented Jan 16, 2019 •
edited
Loading

Let's move all classes inside interfaces to outside. For example, RqHeaders.Base. We should extract the class Base to outside, renaming it to ´RqHeadersBase`. Reasons:

  • It will simplify the interfaces a lot
  • It will separate interfaces and interfaces
  • It will standardize all classes names, avoiding "dot" in the middle of name
  • Cactoos project already doing it
@0crat
Copy link
Collaborator

0crat commented Jan 16, 2019

@paulodamaso/z please, pay attention to this issue

@fabriciofx fabriciofx changed the title Move all classes inside interfaces to out Move all classes inside interfaces to outside Jan 16, 2019
Kartofanych added a commit to Kartofanych/takes that referenced this issue Dec 14, 2024
@Kartofanych
fix yegor256#945
f6f169b
Kartofanych added a commit to Kartofanych/takes that referenced this issue Dec 14, 2024
@Kartofanych
fix yegor256#945
f047e75
Kartofanych added a commit to Kartofanych/takes that referenced this issue Dec 14, 2024
@Kartofanych
fix yegor256#945
a47374f
Kartofanych added a commit to Kartofanych/takes that referenced this issue Dec 14, 2024
@Kartofanych
fix yegor256#945
6c2dae7
@Kartofanych Kartofanych linked a pull request Dec 14, 2024 that will close this issue
Open
Kartofanych added a commit to Kartofanych/takes that referenced this issue Dec 14, 2024
@Kartofanych
fix yegor256#945
a89631f
Kartofanych added a commit to Kartofanych/takes that referenced this issue Dec 14, 2024
@Kartofanych
fix yegor256#945
58a5359
@Kartofanych Kartofanych mentioned this issue Dec 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix https://github.com/yegor256/takes/issues/945 Kartofanych/takes
2 participants
@fabriciofx @0crat