Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix https://github.com/yegor256/takes/issues/945 #1372

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kartofanych
Copy link

@Kartofanych Kartofanych commented Dec 14, 2024

move RqHrefSmart and RqHrefBase out of interface

@Kartofanych Kartofanych force-pushed the move-rq-href-realizations-out-of-interface branch from a89631f to 58a5359 Compare December 14, 2024 21:41
@Kartofanych
Copy link
Author

@yegor256 check please

@yegor256
Copy link
Owner

@Kartofanych what is the motivation for this? We have certain design style already, where supplementary classes stay inside interfaces. Why changing this for these particular ones?

@Kartofanych
Copy link
Author

Kartofanych commented Dec 17, 2024

@Kartofanych what is the motivation for this? We have certain design style already, where supplementary classes stay inside interfaces. Why changing this for these particular ones?

this is fix of issue #945
you asked to check issues that repository has - i found this one
problem is that interface contains its implementations inside - its not good practice according to issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants