#624 - Removing 'excludes' of FindBuging #647

dalifreire · 2016-03-09T10:31:21Z

Issue #624 - Solving puzzle 574-2964594e in pom.xml.

Fixing and removing the following 'excludes' of FindBugs in the pom.xml file:

findbugs:org.takes.facets.fork.FkRegex$2 SIC_INNER_SHOULD_BE_STATIC_ANON
findbugs:org.takes.http.FtCLI$3 SIC_INNER_SHOULD_BE_STATIC_ANON
findbugs:org.takes.http.MainRemote$1 SIC_INNER_SHOULD_BE_STATIC_ANON
findbugs:org.takes.rq.RqMultipart$Base VA_FORMAT_STRING_USES_NEWLINE

30 minutes to implement this task. It is not enough because the problem is much bigger and requires more work than the slotted time allows. A new puzzle was created so that can be resolved by other people.

dalifreire · 2016-03-11T03:02:02Z

@davvd Could you find someone to review it?

davvd · 2016-03-11T09:41:04Z

@dalifreire Many thanks for the PR, let me find a reviewer for it

davvd · 2016-03-11T09:58:58Z

@carlosmiranda review this one, please

carlosmiranda · 2016-03-14T00:31:50Z

@dalifreire looks quite good, thanks!

carlosmiranda · 2016-03-14T00:31:54Z

@rultor merge please

rultor · 2016-03-14T00:32:40Z

@rultor merge please

@carlosmiranda Thanks for your request. @yegor256 Please confirm this.

yegor256 · 2016-03-15T01:31:30Z

src/main/java/org/takes/http/MainRemote.java

+            } catch (final InvocationTargetException ex) {
+                throw new IllegalStateException(ex);
+            } catch (final IllegalAccessException ex) {
+                throw new IllegalStateException(ex);


@dalifreire see http://www.yegor256.com/2015/12/01/rethrow-exceptions.html

@yegor256 Done!

yegor256 · 2016-03-15T01:31:39Z

@dalifreire one comment above

Throwing an Exception Without Proper Context Is a Bad Habit

dalifreire · 2016-03-15T11:49:21Z

@carlosmiranda @yegor256 Thanks for review. Could you take a look if everything is right now?

yegor256 · 2016-03-15T20:47:45Z

src/main/java/org/takes/http/MainRemote.java

+                        this.method.getName()
+                        ),
+                    ex
+                    );


@dalifreire this indentation looks strange to me :) and a few lines above too

@yegor256 Fixed, thanks! :)

yegor256 · 2016-03-15T20:48:13Z

@dalifreire looks good to me, but there is something wrong with indentation, see above

dalifreire · 2016-03-15T21:13:19Z

@yegor256 Indentation fixed! Thanks! Please, check and merge...

yegor256 · 2016-03-17T04:30:02Z

@rultor try to merge

rultor · 2016-03-17T04:30:52Z

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2016-03-17T05:21:20Z

@rultor try to merge

@dalifreire @yegor256 Oops, I failed. You can see the full log here (spent 50min)

+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
+ echo 'waiting for AppVeyor build 2466: running'
waiting for AppVeyor build 2466: running
+ sleep 5s
+ true
++ jq -r .build.status
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/2466
+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
+ echo 'waiting for AppVeyor build 2466: running'
waiting for AppVeyor build 2466: running
+ sleep 5s
+ true
++ jq -r .build.status
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/2466
+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
+ echo 'waiting for AppVeyor build 2466: running'
waiting for AppVeyor build 2466: running
+ sleep 5s
+ true
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/2466
++ jq -r .build.status
+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
+ echo 'waiting for AppVeyor build 2466: running'
waiting for AppVeyor build 2466: running
+ sleep 5s
+ true
++ jq -r .build.status
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/2466
+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
+ echo 'waiting for AppVeyor build 2466: running'
waiting for AppVeyor build 2466: running
+ sleep 5s
+ true
++ jq -r .build.status
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/2466
+ status=failed
+ '[' failed == null ']'
+ '[' failed == success ']'
+ '[' failed == failed ']'
+ echo 'see https://ci.appveyor.com/project/yegor256/takes/build/2466'
see https://ci.appveyor.com/project/yegor256/takes/build/2466
+ exit 1
container 6da7106ef503e04ebe4711b307751144bb41a18cea14130d20fa18f47e0c9348 is dead
Thu Mar 17 05:21:11 UTC 2016

yegor256 · 2016-03-17T17:39:07Z

@rultor try to merge again

rultor · 2016-03-17T17:39:23Z

@rultor try to merge again

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

yegor256 · 2016-03-17T17:39:36Z

@dalifreire I can't "check", you have to create a ticket if you think that the project is broken, see http://www.yegor256.com/2015/01/15/how-to-cut-corners.html

rultor · 2016-03-17T18:45:47Z

@rultor try to merge again

@dalifreire @yegor256 Oops, I failed. You can see the full log here (spent 1hr)

+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
+ echo 'waiting for AppVeyor build 2473: running'
waiting for AppVeyor build 2473: running
+ sleep 5s
+ true
++ jq -r .build.status
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/2473
+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
+ echo 'waiting for AppVeyor build 2473: running'
waiting for AppVeyor build 2473: running
+ sleep 5s
+ true
++ jq -r .build.status
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/2473
+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
+ echo 'waiting for AppVeyor build 2473: running'
waiting for AppVeyor build 2473: running
+ sleep 5s
+ true
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/2473
++ jq -r .build.status
+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
+ echo 'waiting for AppVeyor build 2473: running'
waiting for AppVeyor build 2473: running
+ sleep 5s
+ true
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/2473
++ jq -r .build.status
+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
+ echo 'waiting for AppVeyor build 2473: running'
waiting for AppVeyor build 2473: running
+ sleep 5s
+ true
++ jq -r .build.status
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/2473
+ status=failed
+ '[' failed == null ']'
+ '[' failed == success ']'
+ '[' failed == failed ']'
+ echo 'see https://ci.appveyor.com/project/yegor256/takes/build/2473'
see https://ci.appveyor.com/project/yegor256/takes/build/2473
+ exit 1
container 50568a4512323429c1cbae95c6191b37ddbb3d4c00ac423519e800b57ebb9e04 is dead
Thu Mar 17 18:45:38 UTC 2016

carlosmiranda · 2016-03-29T00:50:00Z

@dalifreire any updates here?

dalifreire · 2016-03-29T09:59:13Z

@carlosmiranda I'm waiting for the merge... take a look here: #654

carlosmiranda · 2016-03-30T00:33:56Z

@rultor merge

rultor · 2016-03-30T00:34:10Z

@rultor merge

@carlosmiranda Thanks for your request. @yegor256 Please confirm this.

…thub.com/dalifreire/takes.git into #624_remove-excludes-findbugs-violations

dalifreire · 2016-04-07T01:43:30Z

@yegor256 ping... @davvd is punishing me for delay.... =)

dalifreire · 2016-04-09T00:53:30Z

@yegor256 Please, could you confirm the merge?

yegor256 · 2016-04-11T07:37:53Z

@rultor try to merge

rultor · 2016-04-11T07:38:57Z

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2016-04-11T07:50:35Z

@rultor try to merge

@yegor256 Done! FYI, the full log is here (took me 12min)

davvd · 2016-04-12T14:06:28Z

@ypshenychka please, let us know what do you think about this ticket, according to our QA rules

davvd · 2016-04-12T14:07:43Z

@rultor deploy now pls

rultor · 2016-04-12T14:08:49Z

@rultor deploy now pls

@davvd OK, I'll try to deploy now. You can check the progress here

ypshenychka · 2016-04-12T14:12:06Z

@carlosmiranda
According to our QA Rules:

The code reviewer found at least three problems in the code.

No issues were found during code review.
Please confirm that you'll try to find at least three problems while future reviews.

rultor · 2016-04-12T14:26:19Z

@rultor deploy now pls

@davvd Done! FYI, the full log is here (took me 17min)

carlosmiranda · 2016-04-12T21:52:27Z

@ypshenychka confirmed, thanks

ypshenychka · 2016-04-13T05:42:47Z

@carlosmiranda Thanks.

ypshenychka · 2016-04-13T05:43:01Z

@davvd Quality is acceptable.

davvd · 2016-04-13T09:57:29Z

@davvd Quality is acceptable.

@ypshenychka thanks for the QA review, we'll work better next time

davvd · 2016-04-13T10:04:44Z

@carlosmiranda 10 mins was added to the account of @ypshenychka (for QA review), in transaction 83433697. Many thanks! 20 mins were added to your account in Transaction ID 83433716 (task took 745 hours and 25 mins). review comments (c=5) added as a bonus. +20 to your rating, your total score is +2316

Removes all excludes of FindBugs.

bc56efa

dalifreire closed this Mar 9, 2016

Fixing some FindBugs violations.

99447a9

dalifreire reopened this Mar 11, 2016

Fixing some PMD violations.

d47bbd3

dalifreire changed the title ~~#624 - Removes all excludes of FindBugs.~~ #624 - Removes 'excludes' of FindBugs. Mar 11, 2016

dalifreire changed the title ~~#624 - Removes 'excludes' of FindBugs.~~ #624 - Removing 'excludes' of FindBuging Mar 11, 2016

dalifreire mentioned this pull request Mar 11, 2016

pom.xml:373-375: Continue fixing FindBugs violations started... #624

Closed

davvd added CR @carlosmiranda 15 mins labels Mar 11, 2016

dalifreire added 2 commits March 11, 2016 07:00

Forces a new AppVeyor build.

eb72bf8

Forces a new build.

5b791ff

yegor256 reviewed Mar 15, 2016
View reviewed changes

Code review fixes.

c87b1eb

Throwing an Exception Without Proper Context Is a Bad Habit

yegor256 reviewed Mar 15, 2016
View reviewed changes

Indentation...

40805ef

dalifreire mentioned this pull request Mar 18, 2016

AppVeyor is dead #654

Closed

Forces a new build.

85fd59f

Forces a new build.

9e8e62f

dalifreire added 2 commits April 6, 2016 22:31

Forces a new build.

b96afa4

Merge branch '#624_remove-excludes-findbugs-violations' of https://gi…

57752b4

…thub.com/dalifreire/takes.git into #624_remove-excludes-findbugs-violations

rultor merged commit 57752b4 into yegor256:master Apr 11, 2016

dalifreire deleted the #624_remove-excludes-findbugs-violations branch April 13, 2016 22:39

#624 - Removing 'excludes' of FindBuging #647

#624 - Removing 'excludes' of FindBuging #647

Conversation

dalifreire commented Mar 9, 2016

dalifreire commented Mar 11, 2016

davvd commented Mar 11, 2016

davvd commented Mar 11, 2016

carlosmiranda commented Mar 14, 2016

carlosmiranda commented Mar 14, 2016

rultor commented Mar 14, 2016

yegor256 Mar 15, 2016

Choose a reason for hiding this comment

dalifreire Mar 15, 2016

Choose a reason for hiding this comment

yegor256 commented Mar 15, 2016

dalifreire commented Mar 15, 2016

yegor256 Mar 15, 2016

Choose a reason for hiding this comment

dalifreire Mar 15, 2016

Choose a reason for hiding this comment

yegor256 commented Mar 15, 2016

dalifreire commented Mar 15, 2016

yegor256 commented Mar 17, 2016

rultor commented Mar 17, 2016

rultor commented Mar 17, 2016

yegor256 commented Mar 17, 2016

rultor commented Mar 17, 2016

yegor256 commented Mar 17, 2016

rultor commented Mar 17, 2016

carlosmiranda commented Mar 29, 2016

dalifreire commented Mar 29, 2016

carlosmiranda commented Mar 30, 2016

rultor commented Mar 30, 2016

dalifreire commented Apr 7, 2016

dalifreire commented Apr 9, 2016

yegor256 commented Apr 11, 2016

rultor commented Apr 11, 2016

rultor commented Apr 11, 2016

davvd commented Apr 12, 2016

davvd commented Apr 12, 2016

rultor commented Apr 12, 2016

ypshenychka commented Apr 12, 2016

rultor commented Apr 12, 2016

carlosmiranda commented Apr 12, 2016

ypshenychka commented Apr 13, 2016

ypshenychka commented Apr 13, 2016

davvd commented Apr 13, 2016

davvd commented Apr 13, 2016