pom.xml:373-375: Continue fixing FindBugs violations started...

[davvd]

Puzzle 574-2964594e in pom.xml:373-375 has to be resolved: Continue fixing FindBugs violations started in #574. #574 turned on the FindBugs, temporarily excluding some classes. Remove all excludes of FindBugs below and fix the issues.... The puzzle was created by sxg on 9-Feb-2016.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code.

---

- ~~`624-78dfe52a`/#660~~ (by Nicolas FILOTTO) - ~~`660-949a08e1`/#678~~ (by Vladimir Maximenko) - ~~`678-b4f3ecf4`/#684~~ (by Vladimir Maximenko) - ~~`678-832c7c24`/#686~~ (by Dalí Freire Dias dos Santos) - ~~`686-bac26563`/#696~~ (by Rui José Gonçalves de Castro) - ~~`686-832c7c24`/#697~~ (by Vladimir Maximenko) - ~~`686-55806871`/#698~~ (by Dalí Freire Dias dos Santos) - `684-70270140`/#692 (by Vladimir Maximenko)

[davvd]

@yegor256 attached this issue to milestone "1.0" (let me know if this is wrong)

[davvd]

@xupyprmv the task is yours, please go ahead

[xupyprmv]

@davvd please find someone else

[davvd]

@davvd please find someone else

@xupyprmv -30 points to your rating

[davvd]

@davvd please find someone else

@xupyprmv right, I'll try to find someone else for this task

[davvd]

@dalifreire it's yours, please go ahead

[dalifreire]

@davvd Thanks. Please, see PR #647.

[davvd]

@davvd Thanks. Please, see PR #647.

@dalifreire will check it soon, thanks

[dalifreire]

@davvd Waiting for #654

[davvd]

@davvd Waiting for #654

@dalifreire OK, let's wait for #654

[davvd]

@yegor256 we waited for #654, it is closed already

[davvd]

@dalifreire you're working with this issue for 15 days already... as a reminder, don't forget to remove the @todo puzzle from the source code... -30 to your rating, your total score is +75

[dalifreire]

@davvd Why? The pull request #647 was created... take a look in the PR and the issue #654.

[dalifreire]

@davvd PR #647 closed, please proceed.

[dalifreire]

@yegor256 Could you talk to @davvd to revert my penalty (30 points) for delay?

[davvd]

@davvd PR #647 closed, please proceed.

@dalifreire thanks for that

[davvd]

@dalifreire this task is not yours any more (took too long), please stop. I'll give you something else... -60 added to your rating, current score is: +15

[dalifreire]

@davvd The task was finished and the PR #647 was merged. I can't understand you.

[dalifreire]

@yegor256 We need your help here.

[davvd]

@essobedo the task is yours,please go ahead

[dalifreire]

@davvd Please, pay attention what you are doing! Why do you not read my messages?

[davvd]

@yegor256 once 624-78dfe52a/#660 puzzle is resolved (later, in another ticket), this ticket will be fully complete

[yegor256]

@dalifreire what do you think is wrong here? the puzzle is still in the code. that's why the ticket is not closed. you missed the deadline and the task was taken away from you. or I miss something?

[dalifreire]

@yegor256 Maybe some misunderstand about PDD happens here. I thought I could create another puzzle based on this ticket... 30 minutes to implement this task is not enough and requires more work than the slotted time allows. So I fixed some things and a new puzzle was created so that can be resolved by other people. Take a look in the PR #647 description.

About the deadline, I'm waiting for you for at least 15 days. I need you (as architect) to confirm the merge.... check the PR #647 and you will see (not my fault). I think the same thing happens in the issue #625.

Maybe I did not understand very well the "rules of the game".

[davvd]

@yegor256 Done, the task is closed

[davvd]

@essobedo No messages from you above, won't pay for now. If I'm wrong, correct me.

[essobedo]

@essobedo No messages from you above, won't pay for now. If I'm wrong, correct me.

@davvd no, you are perfectly right

[dalifreire]

@yegor256 Did you read my last message? If no, could you read and tell me if I didn't understand very well the PDD?

[yegor256]

@dalifreire I didn't understand the question... but please keep in mind that everything (!) is your fault. check our policy, especially this par: http://at.teamed.io/policy.html#7 make sense?

[dalifreire]

@yegor256 I don't care about the payment. I'm trying to understand the Puzzle Driven Development.

My questions are:

• Can I create another puzzle based on existing ticket? If I think that the 30 minutes is not enough because the problem is much bigger and requires more work than the slotted time allows (the PR #624 - Removing 'excludes' of FindBuging #647 was created and merged because I thought that we can break a puzzle into minor pieces).
• Every pull request needs the architect approval to be merged. So if the architect (you for takes project) delays more than one week to do the approval, the PR author must be penalized?
• Why the Project Manager never read the questions?
• Looks like the same problem (your delay to approve the PR) happens in the task #625: RqMultipartTest.java:91-98: This test is using RqGreedy... #653.

[yegor256]

@dalifreire 1) yes, you can create as many puzzles in your branch as you wish; 2) yes, if PR review is delayed the author of the PR is penalized; 3) PM reads questions and replies, as much as possible, but don't rely too much on communications here, nobody really cares about your questions, only about your results, try to figure out yourself what to do (I would strongly recommend to read all articles listed at the top of this page: http://at.teamed.io/policy.html ); 4) maybe

[davvd]

@yegor256 last puzzled solved 684-70270140/#692