Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TkCors.java:53-56: Remove PMD.AvoidDuplicateLiterals exclude here and... #692

Closed
davvd opened this issue Jun 24, 2016 · 16 comments
Closed

Comments

@davvd
Copy link

davvd commented Jun 24, 2016

Puzzle 684-70270140 in src/main/java/org/takes/tk/TkCors.java:53-56 has to be resolved: Remove PMD.AvoidDuplicateLiterals exclude here and in {@link RsPrettyJson}, {@link RsPrettyXml}. Note that this puzzle depends on yegor256/qulice#760. Note that this puzzle has partially overlap with #686... The puzzle was created by Maksimenko Vladimir on 18-Jun-2016.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code.

@davvd
Copy link
Author

davvd commented Jun 24, 2016

@xupyprmv the task is yours, please go ahead

@davvd
Copy link
Author

davvd commented Jun 24, 2016

@yegor256 since the ticket has no milestone I set it to 1.0

@davvd davvd added this to the 1.0 milestone Jun 24, 2016
@xupyprmv
Copy link
Contributor

@davvd I'm waiting for yegor256/qulice#760 here.

@davvd
Copy link
Author

davvd commented Jun 25, 2016

@davvd I'm waiting for yegor256/qulice#760 here.

@xupyprmv OK, take your time

@xupyprmv
Copy link
Contributor

xupyprmv commented Aug 9, 2016

@davvd I'm waiting for #697 here.

@davvd
Copy link
Author

davvd commented Aug 10, 2016

@davvd I'm waiting for #697 here.

@xupyprmv yes, right, let's wait for #697

@xupyprmv
Copy link
Contributor

@davvd I added PR #710. Please find someone to review.

@davvd
Copy link
Author

davvd commented Aug 15, 2016

@davvd I added PR #710. Please find someone to review.

@xupyprmv thank you!

@davvd
Copy link
Author

davvd commented Aug 18, 2016

@yegor256 FYI, the issue we were waiting for (#697) is fixed

@xupyprmv
Copy link
Contributor

@davvd #710 was merged. Please, close this thicket.

@davvd
Copy link
Author

davvd commented Aug 19, 2016

@davvd #710 was merged. Please, close this thicket.

@xupyprmv sure thanks

@davvd
Copy link
Author

davvd commented Aug 21, 2016

@yegor256 The task is done, thanks all, I am closing it

@davvd davvd closed this as completed Aug 21, 2016
@davvd
Copy link
Author

davvd commented Aug 21, 2016

@elenavolokhova please, help us to evaluate quality here, as per par.24

@elenavolokhova
Copy link

@davvd Looks good!

@davvd
Copy link
Author

davvd commented Aug 22, 2016

@davvd Looks good!

@elenavolokhova thanks!

@davvd
Copy link
Author

davvd commented Aug 22, 2016

@xupyprmv just added 10 mins to @elenavolokhova (for QA), payment ID is 97430079. Many thanks! 23 mins were added to your account in Transaction ID AP-6WA17721YT799422D (task took 45 hours and 4 mins). the bonus for fast delivery (m=2704). +23 added to your rating, at the moment it is: +128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants