Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pom.xml:338-340: Continue fixing FindBugs violations started... #660

Closed
davvd opened this issue Apr 12, 2016 · 21 comments
Closed

pom.xml:338-340: Continue fixing FindBugs violations started... #660

davvd opened this issue Apr 12, 2016 · 21 comments

Comments

@davvd
Copy link

davvd commented Apr 12, 2016

Puzzle 624-78dfe52a in pom.xml:338-340 has to be resolved: Continue fixing FindBugs violations started in #624. #624 turned on the FindBugs, temporarily excluding some classes. Remove all excludes of FindBugs below and fix the issues.... The puzzle was created by Dalí Freire on 29-Mar-2016.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code.


- ~~`660-949a08e1`/#678~~ (by Vladimir Maximenko) - ~~`678-b4f3ecf4`/#684~~ (by Vladimir Maximenko) - ~~`678-832c7c24`/#686~~ (by Dalí Freire Dias dos Santos) - ~~`686-bac26563`/#696~~ (by Rui José Gonçalves de Castro) - ~~`686-832c7c24`/#697~~ (by Vladimir Maximenko) - ~~`686-55806871`/#698~~ (by Dalí Freire Dias dos Santos) - `684-70270140`/#692 (by Vladimir Maximenko)
@davvd
Copy link
Author

davvd commented Apr 12, 2016

@essobedo please proceed, it's yours

@davvd
Copy link
Author

davvd commented Apr 12, 2016

@yegor256 I set milestone here to 1.0, let me know if it is wrong

@davvd davvd added this to the 1.0 milestone Apr 12, 2016
@essobedo
Copy link
Contributor

@davvd here is my PR #662 please find a reviewer

@davvd
Copy link
Author

davvd commented Apr 13, 2016

@davvd here is my PR #662 please find a reviewer

@essobedo OK, sure

@essobedo
Copy link
Contributor

@davvd waiting for yegor256/qulice#762. Indeed I need some help from the Qulice Team to fix it properly

@essobedo
Copy link
Contributor

@davvd could you please confirm that you approve that this issue depends on yegor256/qulice#762 ?

@essobedo
Copy link
Contributor

@davvd waiting for yegor256/qulice#762

@essobedo
Copy link
Contributor

@davvd @yegor256 this ticket depends on yegor256/qulice#762 so we should have "Impediment" in the details of this ticket in my agenda, shouldn't we?

@essobedo
Copy link
Contributor

@davvd need more time to get the required information from yegor256/qulice#762

@davvd
Copy link
Author

davvd commented Apr 22, 2016

@davvd need more time to get the required information from yegor256/qulice#762

@essobedo of course, thanks for letting me know, take your time

@essobedo
Copy link
Contributor

@davvd FYI yegor256/qulice#762 is now closed, the PR has been approved by the reviewer, so now we only wait for the architect to review it

@essobedo
Copy link
Contributor

@davvd need more time to be validated by the architect

@davvd
Copy link
Author

davvd commented Apr 30, 2016

@davvd need more time to be validated by the architect

@essobedo sure, take your time, I know about this pause

@essobedo
Copy link
Contributor

@davvd the PR has been merged, you can proceed, thx

@davvd
Copy link
Author

davvd commented May 16, 2016

@yegor256 there is a puzzle in this code 660-949a08e1/#678, we'll resolve it later

@davvd
Copy link
Author

davvd commented May 17, 2016

@yegor256 Thanks all, I am closing

@davvd davvd closed this as completed May 17, 2016
@davvd
Copy link
Author

davvd commented May 17, 2016

@ypshenychka please, review this issue for QA compliance, as per par.24

@ypshenychka
Copy link

@davvd Quality is good.

@davvd
Copy link
Author

davvd commented May 17, 2016

@davvd Quality is good.

@ypshenychka many thanks

@davvd
Copy link
Author

davvd commented May 17, 2016

@essobedo just added 10 mins to @ypshenychka (for QA), payment ID is 87004567; Much obliged! I have added 30 mins to your account in payment "87004591", 814 hours and 23 mins spent; +30 added to your rating, current score is: +613

@davvd
Copy link
Author

davvd commented Sep 30, 2016

@yegor256 the last puzzle 684-70270140/#692 originated from here solved

0pdd referenced this issue Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants