Let's turn on findbugs

[exper0]

Currently it's excluded in qulice configuration. Why is it?

---

- ~~`517-9858229b`/#574~~ (by Sebin George) - ~~`574-2964594e`/#624~~ (by ) - ~~`624-78dfe52a`/#660~~ (by Nicolas FILOTTO) - ~~`660-949a08e1`/#678~~ (by Vladimir Maximenko) - ~~`678-b4f3ecf4`/#684~~ (by Vladimir Maximenko) - ~~`678-832c7c24`/#686~~ (by Dalí Freire Dias dos Santos) - ~~`686-bac26563`/#696~~ (by Rui José Gonçalves de Castro) - ~~`686-832c7c24`/#697~~ (by Vladimir Maximenko) - ~~`686-55806871`/#698~~ (by Dalí Freire Dias dos Santos) - `684-70270140`/#692 (by Vladimir Maximenko)

[yegor256]

@exper0 let's try to turn them on...

[davvd]

@exper0 we will find someone to do this task, soon

[davvd]

@exper0 there is no milestone yet, so I set it to 1.0

[davvd]

@ddaanniieell01 could you please pick this up? This article explains how we work. Any technical questions you may ask right here; The cost of this task is 30 mins (this is exactly how much will be paid, not less not more), when the task is done

[davvd]

@exper0 thanks a lot for reporting, 15 mins added to your acc, pmt ID AP-3LR38608T1136251D

[davvd]

@alexey-krylov this task is yours, please help (see our key principles of work). If you have any technical questions, don't hesitate to ask right here; The budget of this task is 30 mins. This is exactly how much time will be compensated, when the task is completed. Read about our Definition of Done

[alexey-krylov]

@davvd ok, i take this task.

[davvd]

@davvd ok, i take this task.

@alexey-krylov thanks

[alexey-krylov]

@yegor256 FindBugs found ~50 errors in Takes. Most of them related to String-from-bytes construction without charset:

new String(byte[])

I propose three options:

1. Use StandardCharsets.UTF_8 everywhere. This option requires to change minimum supportable JDK to 1.7.
2. Use constant "UTF-8" everywhere (make it public static).
3. Suppress this FindBugs check

Please suggest with selection. I don't know Takes popularity level in environments based on Java6.
As you know Oracle public support for Java6 and 7 has been stopped in 2013 and 2015 respectively (http://www.oracle.com/technetwork/java/eol-135779.html). Maybe it will be good idea to migrate Takes to Java8?

[alexey-krylov]

@yegor256, @exper0 one more question - what result expected with resolution of this issue: "enabled FindBugs" or "enabled FindBugs + code matched its checks"?

[exper0]

@alexey-krylov Ideally you should enable findbugs and fix issues it causes. If there are too many issues you need to fix at least some of them and exclude the remaining issues from check (using specific exclude filters). Also you need to create puzzle to for the other developer to fix the remaining issues (see http://www.yegor256.com/2009/03/04/pdd.html)

[alexey-krylov]

@exper0 most of issues related to 'new String(byte[])' construct. What do you think about best solution here?

[yegor256]

@alexey-krylov let's upgrade to Java 7

[davvd]

@sebing please go ahead, it's your task now, keep this in mind, and don't hesitate to ask any technical questions you may have... The budget of this issue is 30 mins, which is exactly how much will be paid when the task is done (see this for explanation)

[sebing]

@davvd I made a pull request(#552).
But the build is failing as it cannot download the maven plugin for checking the java version.

[davvd]

@davvd I made a pull request(#552).
But the build is failing as it cannot download the maven plugin for checking the java version.

@sebing how can I help?

[yegor256]

@sebing read this please: http://www.yegor256.com/2015/02/16/it-is-not-a-school.html

[davvd]

@exper0 there is a puzzle in this code 517-9858229b/#574, we'll resolve it later

[sebing]

@davvd Can we close this issue as the merge request (#552) accepted?

[davvd]

@davvd Can we close this issue as the merge request (#552) accepted?

@sebing you should ask ticket author to close it, see http://www.yegor256.com/2014/11/24/principles-of-bug-tracking.html

[sebing]

@exper0 Can we close this issue as the merge request (#552) was accepted?

[exper0]

@sebing sure, thanks

[sebing]

@exper0 thanks.

[sebing]

@davvd This task is finished and closed.

[davvd]

@davvd This task is finished and closed.

@sebing OK thanks

[davvd]

@elenavolokhova please, review this ticket for compliance with our QA rules

[elenavolokhova]

@davvd Quality is good here.

[davvd]

@davvd Quality is good here.

@elenavolokhova thanks for the review

[davvd]

@sebing just added 10 mins to @elenavolokhova (for QA), payment ID is 77172947... done, I added 30 mins in payment 56bca102adaf562e9b00032e, 305 hours and 13 mins spent to complete this... added +30 to your rating, now it is equal to +45

[davvd]

@exper0 the last puzzle 684-70270140/#692 solved