Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PsLinkedinTest.java:57-59: After upgrade to qulice 0.16.4... #696

Closed
davvd opened this issue Jul 2, 2016 · 13 comments
Closed

PsLinkedinTest.java:57-59: After upgrade to qulice 0.16.4... #696

davvd opened this issue Jul 2, 2016 · 13 comments

Comments

@davvd
Copy link

davvd commented Jul 2, 2016

Puzzle 686-bac26563 in src/test/java/org/takes/facets/auth/social/PsLinkedinTest.java:57-59 has to be resolved: After upgrade to qulice 0.16.4 we have to fix ExcessiveMethodLength PMD warings in this classe. Fix this warning and rid of the PMD suppression here.... The puzzle was created by Dalí Freire on 19-Jun-2016.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code.

@davvd
Copy link
Author

davvd commented Jul 2, 2016

@yegor256 there is no milestone yet, so I set it to 1.0

@davvd davvd added this to the 1.0 milestone Jul 2, 2016
@davvd
Copy link
Author

davvd commented Jul 13, 2016

@rui-castro This task is yours, please go ahead keeping in mind this. If any questions, don't hesitate to ask right here... The budget of this issue is 30 mins, which is exactly how much will be paid when the task is done (see this for explanation)

@rui-castro
Copy link
Contributor

@davvd My PR is #701.

@rui-castro
Copy link
Contributor

@davvd Travis build for my PR is failing (https://travis-ci.org/yegor256/takes/jobs/144747825#L673) but it has nothing to do with my code.
Should I open a new bug issue?

@rui-castro
Copy link
Contributor

@davvd The PR is merged, can you close this issue?

@davvd
Copy link
Author

davvd commented Jul 24, 2016

@yegor256 Thanks all, closed

@davvd davvd closed this as completed Jul 24, 2016
@davvd
Copy link
Author

davvd commented Jul 24, 2016

@elenavolokhova please, review this ticket for compliance with our QA rules

@elenavolokhova
Copy link

@davvd Looks good!

@davvd
Copy link
Author

davvd commented Jul 24, 2016

@davvd Looks good!

@elenavolokhova thanks a lot

@davvd
Copy link
Author

davvd commented Jul 24, 2016

@rui-castro paied 10 mins to @elenavolokhova for QA review (payment ID is 94213618)

thanks, I just added 30 mins to your account, payment AP-26643984XB577051C, 237 hours and 49 mins spent

+30 added to your rating, current score is: +60

@rui-castro
Copy link
Contributor

@davvd Thank you

@rui-castro
Copy link
Contributor

@davvd I'm ready for a new task.

@davvd
Copy link
Author

davvd commented Jul 25, 2016

@davvd Thank you

@rui-castro you are welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants