Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minor fix to VList and VTag to conform with #820 #835

Closed
wants to merge 1 commit into from
Closed

Add minor fix to VList and VTag to conform with #820 #835

wants to merge 1 commit into from

Conversation

trivigy
Copy link
Contributor

@trivigy trivigy commented Dec 29, 2019

Basically this just fixes the html macro children processing for Vlist and VTag the same way I implemented it in VComp.

@trivigy
Copy link
Contributor Author

trivigy commented Dec 29, 2019

@jstarry the changes in tests/macro/html-block-fail.stderr are purely cosmetic. The same fails still fail but the error messages just changed a little bit.

@trivigy trivigy changed the title Add minor fix to VList to conform with #820 Add minor fix to VList and VTag to conform with #820 Dec 29, 2019
@jstarry
Copy link
Member

jstarry commented Jan 4, 2020

@trivigy your changes introduced in #820 created a regression. See #842

Could you please create a new PR that:

  1. Re-introduces changes from Improve nested html! expansion by unwrapping VNodes #820
  2. Includes the changes here in Add minor fix to VList and VTag to conform with #820 #835
  3. Fixes the regression in if and else have incompatible types: VChild VNode #839

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants