Revert "Improve nested html! expansion by unwrapping VNodes (#820)" #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
added a commit
that referenced
this pull request
Jan 6, 2020
…843) * Revert "Revert "Improve nested html! expansion by unwrapping VNodes (#820)" (#842)" This reverts commit 70862a4 * Add minor fix to VList to conform with #820 * Add unittest for the regression bug #839 * Resolve #839 regression issue introduced by #820 * wip * Revert "Resolve #839 regression issue introduced by #820" This reverts commit 34dc935. * Use explicit html_nested * Remove NodeSeq from prelude * Clean up tests * Add list and tag tests * Revert vtag children change Co-authored-by: Justin Starry <justin.m.starry@gmail.com>
llebout
pushed a commit
to llebout/yew
that referenced
this pull request
Jan 20, 2020
…#820)" (yewstack#842) This reverts commit a900fbe.
llebout
pushed a commit
to llebout/yew
that referenced
this pull request
Jan 20, 2020
…ewstack#843) * Revert "Revert "Improve nested html! expansion by unwrapping VNodes (yewstack#820)" (yewstack#842)" This reverts commit 70862a4 * Add minor fix to VList to conform with yewstack#820 * Add unittest for the regression bug yewstack#839 * Resolve yewstack#839 regression issue introduced by yewstack#820 * wip * Revert "Resolve yewstack#839 regression issue introduced by yewstack#820" This reverts commit 34dc935. * Use explicit html_nested * Remove NodeSeq from prelude * Clean up tests * Add list and tag tests * Revert vtag children change Co-authored-by: Justin Starry <justin.m.starry@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a900fbe.
The changes introduced in #820 resulted in a regression. Fixes: #839