Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.16.6 #1856

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Version 1.16.6 #1856

merged 2 commits into from
Feb 9, 2024

Conversation

EmilyZhang777
Copy link
Contributor

@EmilyZhang777 EmilyZhang777 commented Feb 1, 2024

Fixes

This PR resolves the following vulnerabilities:

bump search-core's version to 2.5.1 to include the latest vulnerabilities fix
remove usages of insecure document method
bump the version of http-cache-semantics (to 4.1.1), get-func-name (to 2.0.2) and terser (to 5.14.2) to resolve vulnerabilities to uncontrolled resource consumption and inefficient regular expression complexity
J=VULN-37771, VULN-37772, VULN-37773, VULN-38373, VULN-38391, VULN-38401
TEST=auto

Added new tests for the chang. Ran npm run test and npm run acceptance.
@EmilyZhang777 EmilyZhang777 requested a review from a team February 1, 2024 19:51
@coveralls
Copy link

coveralls commented Feb 1, 2024

Coverage Status

coverage: 62.02% (+0.6%) from 61.411%
when pulling 2d3c39e on hotfix/v1.16.6
into dc3b171 on master.

benmcginnis
benmcginnis previously approved these changes Feb 2, 2024
Copy link
Contributor

@nmanu1 nmanu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add the release notes to the PR description? you also need to bump the package version via this PR: #1854

* Change icons from divs to spans

* Change icons from divs to spans

* Add display styling to buttonImage css

* Remove whitespace after css styling line

* Fix styling to mimic div styling

* Add styling to loading indicator and revert changes to voiceSearchIcon

* Remove loading indicator styling

* Add styling to SearchBar-customLoadingImage

* Address comments
@likimmy likimmy changed the title Version 1.16.6 Version 1.16.7 Feb 9, 2024
@likimmy likimmy changed the title Version 1.16.7 Version 1.16.6 Feb 9, 2024
@likimmy likimmy merged commit a8bb7cc into master Feb 9, 2024
36 of 40 checks passed
@likimmy likimmy deleted the hotfix/v1.16.6 branch February 9, 2024 18:23
@nmanu1 nmanu1 restored the hotfix/v1.16.6 branch February 9, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants