Resolve Vulnerabilities #1855
Resolve Vulnerabilities #1855
Conversation
Merge master (v1.16.5) into develop
EmilyZhang777
force-pushed
the
dev/vulnerabilities
branch
from
ec5f907 to
f945c1d
Compare
| const searchInputEl = wrapper.find('.js-yxt-FilterOptions-filter'); | ||
| expect(searchInputEl).toHaveLength(1); | ||
|
|
||
| // empty input |
There was a problem hiding this comment.
can we split each of these cases into separate tests? right now, if one case fails, we won't run any cases after it. it would also make it easier to debug if it fails in the future
There was a problem hiding this comment.
I think they fit better in a single test as the initial config settings are the same only the input in the UI changed. Ack
There was a problem hiding this comment.
if you want to reuse the config settings, you could pull out the config variable. or you could put all the tests into a describe block and do all the setup in the beforeEach
| @@ -448,21 +448,21 @@ export default class FilterOptionsComponent extends Component { | |||
| if (!filter) { | |||
| filterOption.classList.remove('hiddenSearch'); | |||
| filterOption.classList.remove('displaySearch'); | |||
| labelEl.innerHTML = labelText; | |||
| labelEl.textContent = labelText; | |||
There was a problem hiding this comment.
in case you haven't already, it would be good to spin up this component locally and test that the text still appears as expected. you should be able to just serve and navigate to the acceptance test page for it and try things out
There was a problem hiding this comment.
The jest test I added already covers what I changed. Ack
This PR resolves the following vulnerabilities:
search-core's version to 2.5.1 to include the latest vulnerabilities fixhttp-cache-semantics(to 4.1.1),get-func-name(to 2.0.2) andterser(to 5.14.2) to resolve vulnerabilities to uncontrolled resource consumption and inefficient regular expression complexityJ=VULN-37771, VULN-37772, VULN-37773, VULN-38373, VULN-38391, VULN-38401
TEST=auto
Added new tests for the chang. Ran
npm run testandnpm run acceptance.