Add entity type dropdown to entityIds StreamScope field #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextaing
reviewed
Sep 7, 2023
nmanu1
reviewed
Sep 8, 2023
There was a problem hiding this comment.
I like the look a lot more!
- can the text for the entity type dropdown be
text-smto match the other inputs? - looks like the heights of the dropdowns don't match exactly?
- can the outer border edges be rounded more to match the saved filters and entity type dropdowns?
packages/studio/src/store/slices/accountContent/createAccountContentSlice.ts
Outdated
Show resolved
Hide resolved
nmanu1
reviewed
Sep 8, 2023
nmanu1
reviewed
Sep 8, 2023
e2e-tests/__screenshots__/darwin/add-entity-page.spec.ts/can-add-an-entity-page-2.png
Outdated
Show resolved
Hide resolved
nmanu1
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an entity type dropdown to the entityIds StreamScope field.
It also adds dynamic fetching of entities once the user scrolls down the bottom of the select.
J=SLAP-2907
TEST=manual
I can specify an entity type, select entity ids, then switch entity type and select more ids
saving the page correctly adds the entity ids to the TemplateConfig