Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entity type dropdown to entityIds StreamScope field #365

Merged
merged 50 commits into from
Sep 9, 2023
Merged
Show file tree
Hide file tree
Changes from 45 commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
b9caff9
wip
oshi97 Sep 5, 2023
9e14c73
add entity type picker
oshi97 Sep 6, 2023
60e9138
remove console log
oshi97 Sep 6, 2023
7eff51d
delete saved template from testing
oshi97 Sep 6, 2023
12845c3
revert management api hardcoded key
oshi97 Sep 6, 2023
77b0585
Updated snapshots for windows-latest 4 of 4
github-actions[bot] Sep 6, 2023
5552a69
Updated snapshots for macos-latest 4 of 4
github-actions[bot] Sep 6, 2023
51023d1
Updated snapshots for windows-latest 1 of 4
github-actions[bot] Sep 6, 2023
31f2acd
Updated snapshots for macos-latest 1 of 4
github-actions[bot] Sep 6, 2023
7bcbd07
Updated snapshots for windows-latest 2 of 4
github-actions[bot] Sep 6, 2023
c5697dd
Updated snapshots for windows-latest 3 of 4
github-actions[bot] Sep 6, 2023
9d3aebe
Updated snapshots for macos-latest 2 of 4
github-actions[bot] Sep 6, 2023
2776f7e
Updated snapshots for macos-latest 3 of 4
github-actions[bot] Sep 6, 2023
581ca6e
controlled value, load on scroll
oshi97 Sep 6, 2023
ad3d5f9
add divider back to entitypicker
oshi97 Sep 6, 2023
1f11915
Updated snapshots for windows-latest 3 of 4
github-actions[bot] Sep 6, 2023
611e080
Updated snapshots for windows-latest 4 of 4
github-actions[bot] Sep 6, 2023
27511d5
Updated snapshots for macos-latest 3 of 4
github-actions[bot] Sep 6, 2023
98fa4c8
Updated snapshots for windows-latest 2 of 4
github-actions[bot] Sep 6, 2023
7aecbfc
Updated snapshots for macos-latest 4 of 4
github-actions[bot] Sep 6, 2023
d2fe628
Updated snapshots for macos-latest 2 of 4
github-actions[bot] Sep 6, 2023
2f1e781
Updated snapshots for macos-latest 1 of 4
github-actions[bot] Sep 6, 2023
272e758
wip before initial refresh pr
oshi97 Sep 6, 2023
3a52b72
Automated linting update and features.json sync
github-actions[bot] Sep 6, 2023
9a38934
Updated snapshots for windows-latest 1 of 4
github-actions[bot] Sep 6, 2023
fbbea90
Updated snapshots for macos-latest 1 of 4
github-actions[bot] Sep 6, 2023
3e53417
Merge branch 'feature/add-page-improvements' into dev/wip-page-oli
oshi97 Sep 7, 2023
d705092
update to work with merge
oshi97 Sep 7, 2023
439de31
Updated snapshots for windows-latest 1 of 4
github-actions[bot] Sep 7, 2023
6009be2
Updated snapshots for macos-latest 1 of 4
github-actions[bot] Sep 7, 2023
c05db58
empty
oshi97 Sep 7, 2023
49f7397
address comments
oshi97 Sep 8, 2023
56ac85e
Updated snapshots for windows-latest 1 of 4
github-actions[bot] Sep 8, 2023
312cc59
Updated snapshots for macos-latest 1 of 4
github-actions[bot] Sep 8, 2023
8639a73
gray
oshi97 Sep 8, 2023
c0d644b
Updated snapshots for windows-latest 1 of 4
github-actions[bot] Sep 8, 2023
5d2a1a7
Updated snapshots for macos-latest 1 of 4
github-actions[bot] Sep 8, 2023
f73f920
styling tweak
oshi97 Sep 8, 2023
6af0ce8
Automated linting update and features.json sync
github-actions[bot] Sep 8, 2023
37a9a4b
update add entity page snapshots
oshi97 Sep 8, 2023
9aed5cc
Updated snapshots for windows-latest 1 of 4
github-actions[bot] Sep 8, 2023
753f5c4
Updated snapshots for macos-latest 1 of 4
github-actions[bot] Sep 8, 2023
8137384
empty
oshi97 Sep 8, 2023
1a7eb95
address comments
oshi97 Sep 8, 2023
cfb236d
add test
oshi97 Sep 8, 2023
aa90419
respond to comments
oshi97 Sep 8, 2023
5d8cc91
deleteroni
oshi97 Sep 8, 2023
c49e050
Updated snapshots for windows-latest 1 of 4
github-actions[bot] Sep 8, 2023
e5c614b
Updated snapshots for macos-latest 1 of 4
github-actions[bot] Sep 8, 2023
5889d67
empty
oshi97 Sep 8, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
nmanu1 marked this conversation as resolved.
Show resolved Hide resolved
nmanu1 marked this conversation as resolved.
Show resolved Hide resolved
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
181 changes: 180 additions & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/studio-plugin/src/http/types/Entities.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export interface EntitiesQueryParams extends BaseQueryParams {
limit: number;
}

interface EntityData {
export interface EntityData {
nmanu1 marked this conversation as resolved.
Show resolved Hide resolved
id: string;
displayName: string;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/studio-plugin/src/http/types/index.ts
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
export { EntitiesResponse } from "./Entities";
export { EntitiesResponse, EntityData } from "./Entities";
export { SavedFilterData } from "./SavedFilters";
1 change: 1 addition & 0 deletions packages/studio/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-modal": "3.16.1",
"react-select": "^5.7.4",
alextaing marked this conversation as resolved.
Show resolved Hide resolved
"react-toastify": "^9.1.1",
"react-tooltip": "^5.18.0",
"tailwind-merge": "^1.8.1",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { StreamScope } from "@yext/studio-plugin";
import { createContext } from "react";
import { createContext, useContext } from "react";

export interface AddPageData {
isStatic: boolean;
Expand All @@ -17,6 +17,13 @@ export interface AddPageContextValue {
actions: AddPageActions;
}

export function useStreamScope() {
const { state, actions } = useContext(AddPageContext);
const { streamScope } = state;
const { setStreamScope } = actions;
return [streamScope, setStreamScope] as const;
}

const AddPageContext = createContext<AddPageContextValue>(
{} as AddPageContextValue
);
Expand Down
Loading
Loading