Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copy for EditStreamScopeModal #381

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Update copy for EditStreamScopeModal #381

merged 3 commits into from
Sep 22, 2023

Conversation

nmanu1
Copy link
Contributor

@nmanu1 nmanu1 commented Sep 21, 2023

Update the copy for the EditStreamScopeModal so it only references "content scope" and not "stream scope".

J=SLAP-2942
TEST=manual

@oshi97 oshi97 merged commit bb01935 into main Sep 22, 2023
1 check passed
@oshi97 oshi97 deleted the dev/edit-scope-copy branch September 22, 2023 17:03
@alextaing alextaing mentioned this pull request Sep 26, 2023
alextaing added a commit that referenced this pull request Sep 26, 2023
## Features
- Layouts can now be added when adding a page. This new step is at the
very end of the Add Page process (#376).
- The Live Preview Button now opens up to the current active page
instead the PageJS landing page (#379).

## Changes
- Updated icons for Components, Containers, and Layouts (#378)!
- The current selected viewport is now highlighted in the dropdown to
keep track of the current viewport (#386).

## Fixes
- The page settings now correctly refers to scope as "Content Scope"
(#381).
- Buggy deploy button behavior has been fixed (#385).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants