Fix Deploy button #385
Merged
Fix Deploy button #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextaing
force-pushed
the
dev/gitdata-hmr
branch
from
5ecd26d
to
6079247
Compare
oshi97
reviewed
Sep 25, 2023
oshi97
reviewed
Sep 25, 2023
oshi97
previously approved these changes
Sep 25, 2023
tmeyer2115
approved these changes
Sep 26, 2023
Merged
alextaing
added a commit
that referenced
this pull request
Sep 26, 2023
## Features - Layouts can now be added when adding a page. This new step is at the very end of the Add Page process (#376). - The Live Preview Button now opens up to the current active page instead the PageJS landing page (#379). ## Changes - Updated icons for Components, Containers, and Layouts (#378)! - The current selected viewport is now highlighted in the dropdown to keep track of the current viewport (#386). ## Fixes - The page settings now correctly refers to scope as "Content Scope" (#381). - Buggy deploy button behavior has been fixed (#385).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Deploy button had unexpected behavior since Git data (
canPush) was not properly updated using HMR. This PR makes sure that on Studio save, updated Git data is sent to Studio. A new type of HMR message was added between studio which handles exclusively Git data, as to not pollute the current HMR message type which is purely studio data from the studio data virtual module.Streamlined the deploy button playwright test to only screenshot the deploy button at three stages: before change, after change, and after deploy.
J=SLAP-2944
TEST=manual,auto