Add Undo Keyboard Shortcut #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextaing
commented
Oct 19, 2023
tmeyer2115
reviewed
Oct 24, 2023
nmanu1
reviewed
Oct 24, 2023
alextaing
force-pushed
the
dev/undo-keyboard-shortcut
branch
from
cecbf92
to
5d01d1f
Compare
nmanu1
reviewed
Oct 25, 2023
tmeyer2115
approved these changes
Oct 25, 2023
Merged
alextaing
added a commit
that referenced
this pull request
Oct 30, 2023
## Features - We have introduced Collapsible Sidebars (#408). - We now support aliased type imports (#411). - The TypeScript utility types Omit, Pick, and Required are now supported for props in a component's prop interface (#413, #414, #415). - The Studio Preview can now display CSS and SCSS styling (#418). - Undo keyboard shortcuts (`cmd+z` for OS X, and `ctrl+z` for other OSes) are now supported in Studio (#417). ## Changes - `_server.tsx` and `_client.tsx` are now reserved template names for PagesJS Repos (#423). ## Fixes - Miscellaneous viewport bugs have been fixed (#424).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the undo keyboard shortcut for Windows (
ctrl+z) and Mac (cmd+z) depending on the user's OS.Note that we
preventDefaultbehavior for this shortcut. In the context of Studio in Storm, this means that when the user is focused on the Studio iframe, the default behavior will be overridden by Studioundo. But, when the user clicks out of the Studio iframe, default behavior will resume.J=SLAP-2954
TEST=manual, auto, SIS