Ensure _client and _server Templates Don't Appear in Studio.
#423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeyer2115
changed the title
_client and _server Templates Don't Appear in Studio.
tmeyer2115
force-pushed
the
dev/ignore-reserved-templates
branch
from
d7998b1
to
d11c575
Compare
nmanu1
reviewed
Oct 25, 2023
packages/studio-plugin/src/orchestrators/ParsingOrchestrator.ts
Outdated
Show resolved
Hide resolved
packages/studio-plugin/src/orchestrators/ParsingOrchestrator.ts
Outdated
Show resolved
Hide resolved
|
|
nmanu1
approved these changes
Oct 25, 2023
Merged
alextaing
added a commit
that referenced
this pull request
Oct 30, 2023
## Features - We have introduced Collapsible Sidebars (#408). - We now support aliased type imports (#411). - The TypeScript utility types Omit, Pick, and Required are now supported for props in a component's prop interface (#413, #414, #415). - The Studio Preview can now display CSS and SCSS styling (#418). - Undo keyboard shortcuts (`cmd+z` for OS X, and `ctrl+z` for other OSes) are now supported in Studio (#417). ## Changes - `_server.tsx` and `_client.tsx` are now reserved template names for PagesJS Repos (#423). ## Fixes - Miscellaneous viewport bugs have been fixed (#424).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures Studio will not display the
_client.tsxor_server.tsxTemplates. These Templates are reserved files in PagesJS. They don't actually correspond to a Page, but instead dictate how SSR works. In the future, we will be able to exclude these files by supporting Globs in the Studio Config's paths. For now, Product does not have the appetite for adding Globs.We now prevent someone from adding a Page in Studio whose filename is
_clientor_server(assuming they're in PagesJS mode).J=SLAP-2960
TEST=auto, manual